https://bugzilla.redhat.com/show_bug.cgi?id=1739838 Vasiliy Glazov <vascom2@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #10 from Vasiliy Glazov <vascom2@xxxxxxxxx> --- Package approved. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GPL (v2)", "GNU General Public License (v2)", "BSD (unspecified)", "GPL (v2 or later)", "Apache License (v2.0)", "ISC License", "Expat License", "BSD 3-clause "New" or "Revised" License", "*No copyright* BSD (unspecified)", "GPL (v3 or later)", "GPL (v3)", "GNU Lesser General Public License (v2.1)", "BSD 3-clause "New" or "Revised" License GPL (v3.0)". 840 files have unknown license. Detailed output of licensecheck in /home/vascom/1739838-qownnotes/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/qt5, /usr/share/qt5/translations [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in qownnotes [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: qownnotes-1.8.4-6.20190810git0302b2c.fc31.x86_64.rpm qownnotes-translations-1.8.4-6.20190810git0302b2c.fc31.noarch.rpm qownnotes-debuginfo-1.8.4-6.20190810git0302b2c.fc31.x86_64.rpm qownnotes-debugsource-1.8.4-6.20190810git0302b2c.fc31.x86_64.rpm qownnotes-1.8.4-6.20190810git0302b2c.fc31.src.rpm qownnotes.x86_64: W: spelling-error %description -l en_US todo -> too, dodo, to do qownnotes.x86_64: W: spelling-error %description -l en_US ownCloud -> own Cloud, own-cloud, overcloud qownnotes.x86_64: W: spelling-error %description -l en_US ownCloud's -> own Cloud's, own-cloud's, cloudiness's qownnotes.x86_64: W: no-manual-page-for-binary QOwnNotes qownnotes-translations.noarch: W: no-documentation qownnotes.src: W: spelling-error %description -l en_US todo -> too, dodo, to do qownnotes.src: W: spelling-error %description -l en_US ownCloud -> own Cloud, own-cloud, overcloud qownnotes.src: W: spelling-error %description -l en_US ownCloud's -> own Cloud's, own-cloud's, cloudiness's 5 packages and 0 specfiles checked; 0 errors, 8 warnings. Rpmlint (debuginfo) ------------------- Checking: qownnotes-debuginfo-1.8.4-6.20190810git0302b2c.fc31.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "ru_RU.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "ru_RU.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). qownnotes-debuginfo.x86_64: W: invalid-url URL: https://www.qownnotes.org <urlopen error [Errno -2] Name or service not known> qownnotes-debugsource.x86_64: W: invalid-url URL: https://www.qownnotes.org <urlopen error [Errno -2] Name or service not known> qownnotes-translations.noarch: W: invalid-url URL: https://www.qownnotes.org <urlopen error [Errno -2] Name or service not known> qownnotes-translations.noarch: W: no-documentation qownnotes.x86_64: W: spelling-error %description -l en_US todo -> too, dodo, to do qownnotes.x86_64: W: spelling-error %description -l en_US ownCloud -> own Cloud, own-cloud, overcloud qownnotes.x86_64: W: spelling-error %description -l en_US ownCloud's -> own Cloud's, own-cloud's, cloudiness's qownnotes.x86_64: W: invalid-url URL: https://www.qownnotes.org <urlopen error [Errno -2] Name or service not known> qownnotes.x86_64: W: no-manual-page-for-binary QOwnNotes 4 packages and 0 specfiles checked; 0 errors, 9 warnings. Source checksums ---------------- https://github.com/pbek/qkeysequencewidget/archive/9f3f19f7e96a001a98a3216fb65381359da8c39e/qkeysequencewidget-9f3f19f.tar.gz : CHECKSUM(SHA256) this package : cd58a149e948731df28ade41f84b47ea2259e5cd8660d9270fdbf5f1a1128639 CHECKSUM(SHA256) upstream package : cd58a149e948731df28ade41f84b47ea2259e5cd8660d9270fdbf5f1a1128639 https://github.com/pbek/qt-piwik-tracker/archive/a497ea0a0e2d7eeb4b3d942691e1a4e7154be954/qtpiwiktracker-a497ea0.tar.gz : CHECKSUM(SHA256) this package : 50c08a8a4a8bb2244d2af99b122334eeabe7bd6fb58a499ffdc46cf4e584c7cc CHECKSUM(SHA256) upstream package : 50c08a8a4a8bb2244d2af99b122334eeabe7bd6fb58a499ffdc46cf4e584c7cc https://github.com/pbek/FakeVim/archive/8f1a58e5e2aff87a0bf40b078e32ae2779dca213/fakevim-8f1a58e.tar.gz : CHECKSUM(SHA256) this package : 825c6f9b0decd9470c4cf6e01500bb185ab95b4225d843736b8e7bb07f04513b CHECKSUM(SHA256) upstream package : 825c6f9b0decd9470c4cf6e01500bb185ab95b4225d843736b8e7bb07f04513b https://github.com/pbek/qtcsv/archive/db3e9a816d91a4773b61312cafa25eff4ddec91c/qtcsv-db3e9a8.tar.gz : CHECKSUM(SHA256) this package : 863d02e1c947dcd4b9beca621197383ce0358c15087414308f22b80a08f4d014 CHECKSUM(SHA256) upstream package : 863d02e1c947dcd4b9beca621197383ce0358c15087414308f22b80a08f4d014 https://github.com/pbek/Qt-Toolbar-Editor/archive/612029c45b7b6c38be8ffe7c600ae6a10edb9006/qttoolbareditor-612029c.tar.gz : CHECKSUM(SHA256) this package : 2bce6f8654aa18400aad2667e3e32ce2794ff97003ede648a34a831ef2087da2 CHECKSUM(SHA256) upstream package : 2bce6f8654aa18400aad2667e3e32ce2794ff97003ede648a34a831ef2087da2 https://github.com/pbek/qmarkdowntextedit/archive/e97d020962f2444cc30d24d0e39c00781b2e0ae1/qmarkdowntextedit-e97d020.tar.gz : CHECKSUM(SHA256) this package : 654498442392bdc761183af6b8c85c31f4583807df3787cdd9b36b734bf35e31 CHECKSUM(SHA256) upstream package : 654498442392bdc761183af6b8c85c31f4583807df3787cdd9b36b734bf35e31 https://github.com/pbek/QOwnNotes/archive/0302b2ca3a4528c5ab3e9f2f9a356e9b41413038/qownnotes-1.8.4.20190810git0302b2c.tar.gz : CHECKSUM(SHA256) this package : 4790f44a3218d5b79e7cd10362383c2c00e400b37f3a66fcad3bf8e993dc8bb4 CHECKSUM(SHA256) upstream package : 4790f44a3218d5b79e7cd10362383c2c00e400b37f3a66fcad3bf8e993dc8bb4 Requires -------- qownnotes (rpmlib, GLIBC filtered): hicolor-icon-theme libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.12)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Network.so.5()(64bit) libQt5Network.so.5(Qt_5)(64bit) libQt5PrintSupport.so.5()(64bit) libQt5PrintSupport.so.5(Qt_5)(64bit) libQt5Qml.so.5()(64bit) libQt5Qml.so.5(Qt_5)(64bit) libQt5Sql.so.5()(64bit) libQt5Sql.so.5(Qt_5)(64bit) libQt5WebSockets.so.5()(64bit) libQt5WebSockets.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libQt5Xml.so.5()(64bit) libQt5Xml.so.5(Qt_5)(64bit) libQt5XmlPatterns.so.5()(64bit) libQt5XmlPatterns.so.5(Qt_5)(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.1)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) rtld(GNU_HASH) qownnotes-translations (rpmlib, GLIBC filtered): qownnotes(x86-64) qownnotes-debuginfo (rpmlib, GLIBC filtered): qownnotes-debugsource (rpmlib, GLIBC filtered): Provides -------- qownnotes: application() application(PBE.QOwnNotes.desktop) bundled(botan) bundled(fakevim) bundled(qkeysequencewidget) bundled(qmarkdowntextedit) bundled(qt-piwik-tracker) bundled(qt-toolbar-editor) bundled(qtcsv) metainfo() metainfo(qownnotes.appdata.xml) qownnotes qownnotes(x86-64) qownnotes-translations: qownnotes-translations qownnotes-debuginfo: debuginfo(build-id) qownnotes-debuginfo qownnotes-debuginfo(x86-64) qownnotes-debugsource: qownnotes-debugsource qownnotes-debugsource(x86-64) Generated by fedora-review 0.7.2 (65d36bb) last change: 2019-04-09 Command line :/usr/bin/fedora-review -b 1739838 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, C/C++, Shell-api Disabled plugins: PHP, Haskell, Python, Ocaml, SugarActivity, R, fonts, Perl, Java Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
