https://bugzilla.redhat.com/show_bug.cgi?id=1739807 Igor Gnatenko <i.gnatenko.brain@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |i.gnatenko.brain@xxxxxxxxx --- Comment #2 from Igor Gnatenko <i.gnatenko.brain@xxxxxxxxx> --- Agree with Elliott, don't create subpackages. Just own directories. For example, https://src.fedoraproject.org/rpms/rust-ripgrep/blob/master/f/rust-ripgrep.spec#_42 * I believe that spec is missing BuildRequires: gettext-devel * Missing BuildRequires: pkgconfig(json-c) * I think you need to unbundle dmidecode and bandwidth (both seem to be GPLv2+, so at least declare bundled provides) * BuildRequires: pkgconfig(libarchive) does not seem to be needed > BuildRequires: pkgconfig(gtk+-3.0) BuildRequires: pkgconfig(gtk+-3.0) >= 3.12.0 > BuildRequires: pkgconfig(ncurses) BuildRequires: pkgconfig(ncursesw) > BuildRequires: pkgconfig(libcpuid) BuildRequires: pkgconfig(libcpuid) >= 0.4.0 > Requires: polkit%{?_isa} This is not really needed, you are fine with just owning appropriate directories (so that there are no dangling dirs on a removal). > %{_datadir}/bash-completion/completions/%{name} %dir %{_datadir}/bash-completion %dir %{_datadir}/bash-completion/completions %{_datadir}/bash-completion/%{name} -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
