https://bugzilla.redhat.com/show_bug.cgi?id=1736017 --- Comment #2 from Hirotaka Wakabayashi <hiwkby@xxxxxxxxx> --- Hello Robert-André, Please check my review. Summary ======= 1. rpmlint 2. naming 3. fedora-review Details ======= 1. rpmlint ---------- Here are the results of rpmlint. ``` $ rpmlint golang-github-nats-io-server-2.0.2-1.fc31.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint ~/rpmbuild/RPMS/noarch/golang-github-nats-io-server-devel-2.0.2-1.fc31.noarch.rpm golang-github-nats-io-server-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/nats-io/nats-server/.goipath 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint ~/rpmbuild/RPMS/x86_64/golang-github-nats-io-server-2.0.2-1.fc31.x86_64.rpm golang-github-nats-io-server.x86_64: W: no-manual-page-for-binary gnatsd 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint ~/rpmbuild/RPMS/noarch/compat-golang-github-nats-io-gnatsd-devel-2.0.2-1.fc31.noarch.rpm compat-golang-github-nats-io-gnatsd-devel.noarch: W: obsolete-not-provided golang-github-nats-io-gnatsd-devel compat-golang-github-nats-io-gnatsd-devel.noarch: W: no-documentation compat-golang-github-nats-io-gnatsd-devel.noarch: W: dangling-relative-symlink /usr/share/gocode/src/github.com/nats-io/gnatsd nats-server 1 packages and 0 specfiles checked; 0 errors, 3 warnings. $ rpmlint ~/rpmbuild/RPMS/x86_64/golang-github-nats-io-server-debugsource-2.0.2-1.fc31.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint ~/rpmbuild/RPMS/x86_64/golang-github-nats-io-server-debuginfo-2.0.2-1.fc31.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ``` 1.1. golang-github-nats-io-server.x86_64: W: no-manual-page-for-binary gnatsd This package should contain man pages for gnatsd. Please see https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages 1.2. compat-golang-github-nats-io-gnatsd-devel.noarch: W: obsolete-not-provided golang-github-nats-io-gnatsd-devel I think this warning is not important if compat-golang-github-nats-io-gnatsd-devel is not a compatible enough replacement for golang-github-nats-io-gnatsd-devel. Probvides: field should be used if compat-golang-github-nats-io-gnatsd-devel is a compatible enough replacement to golang-github-nats-io-gnatsd-devel. Please see https://docs.fedoraproject.org/en-US/packaging-guidelines/#renaming-or-replacing-existing-packages 1.3. compat-golang-github-nats-io-gnatsd-devel.noarch: W: no-documentation I think this warning is not important because this package provides a symbolic link of "/usr/share/gocode/src/github.com/nats-io/gnatsd" to /usr/share/gocode/src/github.com/nats-io/nats-server/. 1.4. compat-golang-github-nats-io-gnatsd-devel.noarch: W: dangling-relative-symlink /usr/share/gocode/src/github.com/nats-io/gnatsd nats-server I think this warning is not important because I confirmed the symlink is valid after installed the package. ``` $ ls /usr/share/gocode/src/github.com/nats-io/gnatsd CODE-OF-CONDUCT.md conf go.mod GOVERNANCE.md logger main.go MAINTAINERS.md README.md ROADMAP.md server test TODO.md $ ls /usr/share/gocode/src/github.com/nats-io/nats-server CODE-OF-CONDUCT.md conf go.mod GOVERNANCE.md logger main.go MAINTAINERS.md README.md ROADMAP.md server test TODO.md ``` 2. naming ---------- golang-github-nats-io-server must be nats-server or something if nats is famous enough that end users do not care about the language their applications are written in. Please see https://eclipseo.fedorapeople.org/guidelines/packaging-guidelines/Golang/#_naming 3. fedora-review ---------------- ``` Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. Licenses found: "Unknown or generated". 1 files have unknown license. Detailed output of licensecheck in /home/vagrant/golang-github-nats-io-server/golang-github-nats-io- server/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/doc/golang-github- nats-io-server-devel(C, locale,, defaulting, Failed, set, to), /usr/share/gocode/src/github.com(golang-github-gosimple-slug-devel, golang-github-tv42-httpunix-devel, golang-github-pborman-uuid-devel, golang-github-d4l3k-messagediff-devel, golang-github-deckarep-set- devel, golang-github-jonboulle-clockwork-devel, golang-github-goftp- server-devel, golang-github-denisenkom-mssqldb-devel, golang-github- magiconair-properties-devel, golang-github-pkg-errors-devel, golang- github-globalsign-mgo-devel, golang-github-ttacon-chalk-devel, golang- github-buger-jsonparser-devel, golang-github-philhofer-fwd-devel, golang-github-oklog-run-devel, golang-github-fsnotify-devel, golang- github-azure-sdk-devel, golang-github-cloudflare-metrics-devel, golang-github-fernet-devel, golang-github-peterbourgon-diskv-devel, golang-github-jedisct1-xsecretbox-devel, golang-github-delve-devel, golang-github-rs-xid-devel, golang-github-rubiojr-vhd-devel, golang- github-onsi-gomega-devel, golang-github-tg-gosortmap-devel, golang- github-circonus-labs-circonusllhist-devel, golang-github-dimchansky- utfbom-devel, golang-github-git-lfs-gitobj-devel, golang-github-moby- buildkit-devel, golang-github-pebbe-zmq4-devel, golang-github- alexflint-filemutex-devel, golang-github-evanphx-json-patch-devel, golang-github-tent-http-link-devel, golang-github-erikstmartin-testdb- devel, golang-github-kolo-xmlrpc-devel, golang-github-jmespath-devel, golang-github-rainycape-memcache-devel, golang-github-ugorji-devel, golang-github-macaron-gzip-devel, golang-github-burntsushi-locker- devel, golang-github-mitchellh-testing-interface-devel, golang-github- hpcloud-tail-devel, golang-github-soundcloud-runit-devel, golang- github-rfjakob-eme-devel, golang-github-klauspost-crc32-devel, golang- github-unknwon-com-devel, golang-github-rwcarlsen-goexif-devel, golang-github-godoctor-devel, golang-github-coreos-iptables-devel, golang-github-googlecloudplatform-cloudsql-proxy-devel, golang-github- rs-cors-devel, golang-github-yosssi-gohtml-devel, golang-github- hashicorp-multierror-devel, golang-github-shiena-ansicolor-devel, golang-github-axiomhq-hyperloglog-devel, golang-github-opencontainers- image-spec-devel, golang-github-shurcool-vfsgen-devel, golang-github- acme-lego-devel, golang-github-gopherjs-devel, golang-github- kevinburke-ssh-config-devel, golang-github-azure-pipeline-devel, golang-github-containerd-fifo-devel, golang-github-minio-devel, compat-golang-github-robfig-cron-devel, golang-github-hashicorp-serf- devel, golang-github-shurcool-httpgzip-devel, golang-github- cosmos72-gomacro-devel, golang-github-git-lfs-netrc-devel, golang- github-vmware-vmw-guestinfo-devel, golang-github-kurin-blazer-devel, golang-github-alecthomas-units-devel, golang-github-koofr-koofrclient- devel, golang-github-mattn-pointer-devel, golang-github-google- martian-devel, golang-github-pkg-sftp-devel, golang-github-xorm-core- devel, golang-github-elazarl-goproxy-devel, golang-github-fullsailor- pkcs7-devel, golang-github-openapi-loads-devel, golang-github-flynn- shlex-devel, golang-github-dlclark-regexp2-devel, golang-github- dustin-humanize-devel, golang-github-racksec-srslog-devel, golang- github-facebookarchive-structtag-devel, golang-github-maruel- panicparse-devel, golang-github-bep-gitmap-devel, golang-github- nwaples-rardecode-devel, golang-github-mitchellh-reflectwalk-devel, golang-github-sourcegraph-annotate-devel, compat-golang-github-chzyer- logex-devel, golang-github-elastic-gosigar-devel, golang-github-grpc- ecosystem-middleware-devel, golang-github-mgutz-ansi-devel, golang- github-marstr-randname-devel, golang-github-microsoft-opengcs-devel, golang-github-aead-chacha20-devel, golang-github-xordataexchange- crypt-devel, golang-github-andreyvit-diff-devel, golang-github- ajstarks-deck-devel, golang-github-crossdock-devel, golang-github- docker-go-devel, golang-github-huandu-xstrings-devel, golang-github- docker-devel, golang-github-inconshreveable-mousetrap-devel, golang- github-jdkato-syllables-devel, golang-github-tarm-serial-devel, golang-github-jackc-pgx-devel, golang-github-hashicorp-hclog-devel, golang-github-ncw-acd-devel, golang-github-anacrolix-dms-devel, golang-github-docker-distribution-devel, golang-github-gomarkdown- markdown-devel, golang-github-google-uuid-devel, golang-github- chrismalek-oktasdk-devel, golang-github-influxdata-cache-devel, golang-github-mitchellh-wordwrap-devel, golang-github-godbus-dbus- devel, golang-github-hashicorp-retryablehttp-devel, golang-github- xeonx-timeago-devel, golang-github-hashicorp-immutable-radix-devel, golang-github-hashicorp-version-devel, golang-github-baiyubin-aliyun- sts-sdk-devel, golang-github-michaelklishin-rabbit-hole-devel, golang- github-containerd-zfs-devel, golang-github-mattn-tty-devel, golang- github-remyoudompheng-bigfft-devel, golang-github-grpc-ecosystem- gateway-devel, golang-github-codegangsta-inject-devel, golang-github- alecthomas-template-devel, golang-github-gin-gonic-autotls-devel, golang-github-sean-seed-devel, golang-github-sirupsen-logrus-devel, golang-github-mxk-flowrate-devel, golang-github-dchest-cssmin-devel, golang-github-axgle-mahonia-devel, golang-github-googleapis-gnostic- devel, golang-github-jedisct1-dlog-devel, golang-github-oxtoacart- bpool-devel, golang-github-hashicorp-plugin-devel, golang-github-tmc- grpc-websocket-proxy-devel, golang-github-macaron-session-devel, golang-github-marcinbor85-gohex-devel, golang-github-azure-autorest- devel, golang-github-facebookgo-atomicfile-devel, golang-github-data- dog-godog-devel, golang-github-pkg-profile-devel, golang-github- dgnorton-goback-devel, golang-github-docker-credential-helpers-devel, golang-github-gosexy-gettext-devel, golang-github-mitchellh- colorstring-devel, golang-github-chai2010-gettext-devel, golang- github-eapache-xerial-snappy-devel, golang-github-t3rm1n4l-mega-devel, golang-github-gorilla-websocket-devel, golang-github-biogo-store- devel, compat-golang-github-commonmark-linkify-devel, golang-github- bradfitz-gomemcache-devel, golang-github-pact-foundation-devel, golang-github-atotto-clipboard-devel, golang-github-weppos- publicsuffix-devel, golang-github-akrennmair-gopcap-devel, golang- github-mitchellh-goamz-devel, golang-github-oneofone-xxhash-devel, golang-github-opendns-vegadns2client-devel, golang-github-glycerine- unsnap-stream-devel, golang-github-spf13-pflag-devel, golang-github- prometheus-client-model-devel, golang-github-jmank88-nuts-devel, golang-github-revel-config-devel, golang-github-jwilder-encoding- devel, golang-github-jfrogdev-gofrog-devel, golang, golang-github- docker-connections-devel, golang-github-armon-socks5-devel, golang- github-gorilla-css-devel, golang-github-m3db-prometheus-client-model- devel, golang-github-xanzy-ssh-agent-devel, golang-github-coreos-pkg- devel, golang-github-blang-semver-devel, golang-github-kit-devel, golang-github-c-bata-prompt-devel, golang-github-xi2-xz-devel, golang- github-rfjakob-gocryptfs-devel, golang-github-xrash-smetrics-devel, golang-github-michaeltjones-walk-devel, golang-github-sql-driver- mysql-devel, golang-github-syndtr-gocapability-devel, golang-github- nightlyone-lockfile-devel, golang-github-wellington-libsass-devel, golang-github-mattn-isatty-devel, golang-github-aclements-gg-devel, golang-github-ghodss-yaml-devel, golang-github-juju-ratelimit-devel, golang-github-uber-jaeger-client-devel, golang-github-pmezard-difflib- devel, golang-github-git-lfs-wildmatch-devel, golang-github-renstrom- dedent-devel, golang-github-rkt-devel, golang-github-h2non-gock-devel, golang-github-masterminds-semver-devel, golang-github-wsxiaoys- terminal-devel, golang-github-gorilla-context-devel, golang-github- nats-io-nkeys-devel, golang-github-peterh-liner-devel, golang-github- zyedidia-pty-devel, golang-github-pborman-getopt-devel, golang-github- phayes-permbits-devel, golang-github-linode-linodego-devel, golang- github-kr-fs-devel, golang-github-nrdcg-auroradns-devel, golang- github-shopify-sarama-devel, golang-github-jtolds-gls-devel, golang- github-dep-devel, golang-github-ryszard-goskiplist-devel, golang- github-mdlayher-genetlink-devel, golang-github-cockroachdb-ttycolor- devel, golang-github-mikioh-ipaddr-devel, golang-github-rogpeppe- fastuuid-devel, golang-github-bifurcation-mint-devel, golang-github- rubyist-tracerx-devel, golang-github-fatih-structs-devel, golang- github-docker-cli-devel, golang-github-gofrs-uuid-devel, golang- github-jellevandenhooff-dkim-devel, golang-github-gophercloud-devel, golang-github-nlopes-slack-devel, golang-github-jinzhu-gorm-devel, golang-github-gorilla-mux-devel, golang-github-nats-io-jwt-devel, golang-github-yudai-gojsondiff-devel, golang-github-gddo-devel, golang-github-klauspost-cpuid-devel, golang-github-lib-pq-devel, golang-github-exponent-io-jsonpath-devel, golang-github-hashicorp- checkpoint-devel, golang-github-rogpeppe-charset-devel, golang-github- jaguilar-vt100-devel, golang-github-gin-gonic-devel, golang-github- burntsushi-toml-devel, golang-github-djherbis-nio-devel, golang- github-franela-goreq-devel, golang-github-client9-gospell-devel, golang-github-dvsekhvalnov-jose2go-devel, golang-github-mreiferson- httpclient-devel, golang-github-jacobsa-crypto-devel, golang-github- hudl-fargo-devel, golang-github-bfirsh-funker-devel, golang-github- cenkalti-backoff-devel, golang-github-mock-devel, golang-github-pkg- xattr-devel, golang-github-vdemeester-shakers-devel, golang-github- influxdb-gomdb-devel, golang-github-openapi-validate-devel, golang- github-gohugoio-hugo-devel, golang-github-markbates-inflect-devel, golang-github-pascaldekloe-goe-devel, golang-github-sermodigital-jose- devel, golang-github-paulrosania-charset-devel, golang-github-onsi- ginkgo-devel, golang-github-openapi-jsonpointer-devel, golang-github- fogleman-gg-devel, compat-golang-github-ldap-devel, golang-github- opentracing-contrib-grpc-devel, golang-github-aliyun-alibaba-cloud- sdk-devel, golang-github-elithrar-simple-scrypt-devel, golang-github- revel-devel, golang-github-clusterhq-flocker-devel, golang-github- hashicorp-scada-client-devel, golang-github-kisom-goutils-devel, golang-github-dchest-safefile-devel, golang-github-data-dog-sqlmock- devel, golang-github-bradfitz-iter-devel, golang-github-joho-godotenv- devel, golang-github-petermattis-goid-devel, golang-github-fatih- color-devel, golang-github-andybalholm-cascadia-devel, golang-github- aws-sdk-devel, golang-github-shopspring-decimal-devel, golang-github- cloudflare-devel, golang-github-yvasiyarov-gorelic-devel, golang- github-google-gopacket-devel, golang-github-google-pprof-devel, golang-github-jsimonetti-rtnetlink-devel, golang-github-samuel- zookeeper-devel, golang-github-krolaw-dhcp4-devel, golang-github- aclements-moremath-devel, golang-github-karrick-godirwalk-devel, golang-github-mailru-easyjson-devel, golang-github-yvasiyarov-metrics- devel, golang-github-zyedidia-glob-devel, golang-github-dnsimple- devel, golang-github-containerd-ttrpc-devel, golang-github-eapache- queue-devel, golang-github-docker-swarmkit-devel, golang-github- sacloud-libsacloud-devel, golang-github-akavel-rsrc-devel, golang- github-manucorporat-stats-devel, golang-github-matttproud-protobuf- extensions-devel, golang-github-justinas-alice-devel, golang-github- jinzhu-inflection-devel, golang-github-andybalholm-brotli-devel, golang-github-marstr-collection-devel, golang-github-franela-goblin- devel, golang-github-yosssi-ace-devel, golang-github-beevik-ntp-devel, golang-github-gogo-googleapis-devel, golang-github- containernetworking-plugins-devel, golang-github-mitchellh-cli-devel, golang-github-sony-gobreaker-devel, golang-github-naoina-toml-devel, golang-github-mholt-caddy-devel, golang-github-theupdateframework- notary-devel, golang-github-jmhodges-levigo-devel, golang-github- fluent-logger-devel, golang-github-op-logging-devel, golang-github- influxdata-flux-devel, golang-github-sasha-s-deadlock-devel, golang- github-xorm-devel, golang-github-xeipuuv-gojsonreference-devel, golang-github-spaolacci-murmur3-devel, golang-github-knz-strtime- devel, golang-github-oschwald-geoip2-devel, golang-github- audriusbutkevicius-cli-devel, golang-github-remeh-sizedwaitgroup- devel, golang-github-mmarkdown-mmark-devel, golang-github-container- storage-interface-spec-devel, golang-github-cpu-goacmedns-devel, golang-github-bitly-simplejson-devel, golang-github-golangplus-fmt- devel, golang-github-hashicorp-msgpack-devel, golang-github-mdlayher- netlink-devel, golang-github-daaku-zipexe-devel, golang-github- valyala-fasttemplate-devel, golang-github-coreos-log-devel, golang- github-vividcortex-gohistogram-devel, golang-github-opentracing-devel, golang-github-containerd-typeurl-devel, golang-github-briandowns- spinner-devel, compat-golang-github-bufio-devel, golang-github-azure- storage-blob-devel, golang-github-mattn-gtk-devel, golang-github- shurcool-sanitized-anchor-name-devel, golang-github-xo-dburl-devel, golang-github-openapi-analysis-devel, golang-github-robertkrimen-otto- devel, golang-github-denverdino-aliyungo-devel, golang-github-nats-io- nuid-devel, golang-github-samalba-dockerclient-devel, golang-github- anacrolix-tagflag-devel, golang-github-opentracing-contrib-stdlib- devel, golang-github-facebookarchive-inject-devel, golang-github- spf13-viper-devel, golang-github-groupcache-devel, golang-github- kardianos-service-devel, golang-github-davecgh-spew-devel, golang- github-cryptix-wav-devel, golang-github-kdar-factorlog-devel, golang- github-calmh-xdr-devel, golang-github-wjdp-htmltest-devel, golang- github-googleapis-gax-devel, golang-github-ovh-devel, golang-github- jsternberg-zap-logfmt-devel, golang-github-jung-kurt-gofpdf-devel, golang-github-okzk-sdnotify-devel, golang-github-armon-circbuf-devel, Failed, compat-golang-github-check-devel, golang-github-billziss-gh- cgofuse-devel, golang-github-linuxkit-virtsock-devel, golang-github- benlaurie-objecthash-devel, golang-github-knieriem-markdown-devel, compat-golang-github-commonmark-markdown-devel, golang-github-abbot- http-auth-devel, golang-github-jamesclonk-vultr-devel, golang-github- daviddengcn-colortext-devel, golang-github-neelance-astrewrite-devel, golang-github-thorduri-libusb-devel, golang-github-client9-plaintext- devel, golang-github-hashicorp-errwrap-devel, golang-github-afex- hystrix-devel, golang-github-mvo5-goconfigparser-devel, defaulting, compat-golang-github-russross-blackfriday-2-devel, golang-github- jacobsa-reqtrace-devel, golang-github-armon-radix-devel, golang- github-tinylib-msgp-devel, golang-github-golangplus-testing-devel, golang-github-dustin-broadcast-devel, golang-github-burntsushi- graphics-devel, golang-github-influxdata-usage-client-devel, golang- github-anmitsu-shlex-devel, golang-github-appc-docker2aci-devel, golang-github-spf13-nitro-devel, golang-github-vishvananda-netns- devel, golang-github-eknkc-amber-devel, golang-github-lucas-clemente- quic-devel, golang-github-oklog-ulid-devel, golang-github-facebookgo- httpdown-devel, golang-github-tambet-asana-devel, golang-github- kylelemons-godebug-devel, golang-github-jessevdk-assets-devel, golang- github-milochristiansen-lua-devel, golang-github-yuin-gopher-lua- devel, compat-golang-github-coreos-bbolt-devel, golang-github-k-sone- critbitgo-devel, golang-github-rakyll-globalconf-devel, golang-github- libgit2-git2go-devel, golang-github-ianlancetaylor-demangle-devel, golang-github-geertjohan-incremental-devel, golang-github-seccomp- libseccomp-devel, golang-github-chaseadamsio-goorgeous-devel, golang- github-zyedidia-poller-devel, golang-github-nkovacs-streamquote-devel, golang-github-disintegration-gift-devel, golang-github- googlecloudplatform-k8s-cloud-provider-devel, golang-github-ziutek- mymysql-devel, golang-github-aybabtme-rgbterm-devel, golang-github- grpc-ecosystem-prometheus-devel, golang-github-openapi-spec-devel, compat-golang-github-macaron-devel, golang-github-serialx-hashring- devel, golang-github-patrickmn-cache-devel, golang-github- jedisct1-clocksmith-devel, golang-github-datadog-zstd-devel, golang- github-aead-poly1305-devel, golang-github-opencontainers-digest-devel, golang-github-bruth-assert-devel, golang-github-gobwas-glob-devel, golang-github-hashicorp-hcl-devel, golang-github-hawkular-client- devel, golang-github-inconshreveable-muxado-devel, compat-golang- github-coreos-etcd-devel, golang-github-linkedin-goavro-devel, golang- github-dsnet-golib-devel, golang-github-google-subcommands-devel, golang-github-cockroachdb-cockroach-devel, golang-github-boombuler- barcode-devel, golang-github-digitalocean-godo-devel, golang- github-k0kubun-ansi-devel, golang-github-google-renameio-devel, golang-github-mitchellh-hashstructure-devel, golang-github- makenowjust-heredoc-devel, golang-github-docker-libtrust-devel, golang-github-influxdata-influxql-devel, golang-github-ijc-gotty- devel, golang-github-spf13-cobra-devel, golang-github-prometheus-tsdb- devel, golang-github-marten-seemann-qtls-devel, golang-github- cbroglie-mapstructure-devel, golang-github-martini-devel, golang- github-unknwon-goconfig-devel, golang-github-d2g-dhcp4-devel, golang- github-xlab-treeprint-devel, golang-github-stathat-devel, golang- github-yvasiyarov-newrelic-platform-devel, golang-github-matryer-try- devel, golang-github-xanzy-cloudstack-devel, golang-github-namedotcom- devel, golang-github-transip-gotransip-devel, golang-github-yudai- golcs-devel, golang-github-ceph-devel, golang-github-teris-io-shortid- devel, golang-github-docker-libnetwork-devel, golang-github-mholt- certmagic-devel, golang-github-nats-io-streaming-devel, golang-github- protobuf-devel, golang-github-mesos-devel, golang-github-sanity-io- litter-devel, golang-github-sourcegraph-syntaxhighlight-devel, golang- github-pquerna-ffjson-devel, locale,, golang-github-sendgrid-devel, compat-golang-github-mail-devel, golang-github-burntsushi-xgbutil- devel, golang-github-containernetworking-cni-devel, golang-github- jedisct1-minisign-devel, golang-github-sap-hdb-devel, golang-github- rcrowley-metrics-devel, golang-github-jmhodges-clock-devel, golang- github-mindprince-gonvml-devel, golang-github-skynetservices-skydns- devel, golang-github-bsphere-le-devel, golang-github-hashicorp-raft- boltdb-devel, compat-golang-github-tylerb-graceful-devel, golang- github-docker-compose-on-kubernetes-devel, golang-github- nicksnyder-i18n-devel, golang-github-auth0-jwt-middleware-devel, golang-github-armon-metrics-devel, golang-github-aliyun-oss-sdk-devel, golang-github-armon-gomdb-devel, golang-github-emicklei-restful- swagger12-devel, golang-github-jimstudt-http-authentication-devel, golang-github-mndrix-tap-devel, golang-github-bep-tocss-devel, golang- github-jefferai-jsonx-devel, golang-github-google-cadvisor-devel, golang-github-davecgh-xdr-devel, golang-github-mrunalp-fileutils- devel, golang-github-openapi-jsonreference-devel, golang-github- opencontainers-selinux-devel, golang-github-src-d-gcfg-devel, golang- github-hashicorp-logutils-devel, golang-github-posener-complete-devel, golang-github-pquerna-cachecontrol-devel, compat-golang-github-cznic- ql-devel, golang-github-oschwald-maxminddb-devel, golang-github- kisielk-sqlstruct-devel, golang-github-disintegration-imaging-devel, golang-github-ianlancetaylor-cgosymbolizer-devel, golang-github-goji- param-devel, golang-github-h2non-parth-devel, golang-github-aphistic- sweet-devel, golang-github-coreos-systemd-devel, golang-github-google- gofuzz-devel, golang-github-docker-units-devel, golang-github-jbenet- context-devel, golang-github-julienschmidt-httprouter-devel, golang- github-dave-jennifer-devel, golang-github-json-iterator-devel, golang- github-opencontainers-runtime-tools-devel, golang-github-containerd- cgroups-devel, golang-github-leveldb-devel, golang-github-oklog-devel, golang-github-bmizerany-perks-devel, golang-github-a8m-tree-devel, golang-github-armon-proxyproto-devel, golang-github-kardianos-osext- devel, golang-github-data-dog-txdb-devel, golang-github-hako-durafmt- devel, golang-github-bshuster-repo-logrus-logstash-hook-devel, golang- github-quobyte-api-devel, golang-github-dsnet-compress-devel, golang- github-jeffail-gabs-devel, golang-github-jessevdk-flags-devel, golang- github-nats-io-devel, golang-github-errors-devel, golang-github- hashicorp-raft-devel, golang-github-martini-contrib-render-devel, golang-github-mattn-runewidth-devel, golang-github-koofr-httpclient- devel, golang-github-pkg-term-devel, golang-github-tonistiigi- vt100-devel, golang-github-d2g-dhcp4client-devel, golang-github-mattn- shellwords-devel, golang-github-10gen-escaper-devel, golang-github- cheekybits-is-devel, golang-github-cloudflare-backoff-devel, golang- github-chzyer-test-devel, golang-github-shopify-logrus-bugsnag-devel, golang-github-spf13-jwalterweatherman-devel, golang-github-hashicorp- hil-devel, golang-github-vbatts-tar-split-devel, golang-github-miekg- dns-devel, golang-github-edsrzf-mmap-devel, golang-github-ryanuber- glob-devel, golang-github-hashicorp-cleanhttp-devel, golang-github- containerd-cni-devel, golang-github-openapi-errors-devel, golang- github-cockroachdb-cockroach-go-devel, golang-github-tonistiigi- fsutil-devel, golang-github-audriusbutkevicius-nat-pmp-devel, golang- github-mdlayher-wifi-devel, golang-github-mattn-ieproxy-devel, golang- github-hashicorp-rootcerts-devel, golang-github-kyokomi-emoji-devel, golang-github-nats-io-gnatsd-devel, golang-github-smartystreets- assertions-devel, golang-github-containerd-cri-devel, golang-github- jedisct1-dnsstamps-devel, golang-github-golangplus-sort-devel, golang- github-codahale-aesnicheck-devel, golang-github-simonferquel-yaml- devel, golang-github-nwidger-jsoncolor-devel, golang-github- blakesmith-ar-devel, golang-github-mwitkow-conntrack-devel, golang- github-google-trillian-devel, golang-github-codahale-hdrhistogram- devel, golang-github-pquerna-otp-devel, golang-github-zyedidia-tcell- devel, golang-github-satori-uuid-devel, golang-github-10gen-openssl- devel, golang-github-vaughan0-ini-devel, golang-github-facebookgo- pidfile-devel, golang-github-karlseguin-ccache-devel, golang-github- lucas-clemente-quic-certificates-devel, golang-github-nbio-st-devel, golang-github-emicklei-restful-devel, golang-github-stretchr-objx- devel, golang-github-smartystreets-goconvey-devel, golang-github- rican7-retry-devel, golang-github-chmduquesne-rollinghash-devel, golang-github-lithammer-dedent-devel, golang-github-openzipkin-zipkin- devel, golang-github-dgrijalva-jwt-devel, golang-github-bmizerany- assert-devel, golang-github-dropbox-sdk-unofficial-devel, golang- github-safchain-ethtool-devel, golang-github-hashicorp-uuid-devel, golang-github-docker-spdystream-devel, compat-golang-github-chzyer- readline-devel, golang-github-gdamore-encoding-devel, golang-github- rogpeppe-internal-devel, golang-github-iij-doapi-devel, golang-github- milochristiansen-axis2-devel, golang-github-hashicorp-sockaddr-devel, golang-github-sevlyar-daemon-devel, golang-github-docker-licensing- devel, golang-github-opencontainers-runtime-spec-devel, golang-github- google-devel, golang-github-lightstep-tracer-common-devel, golang- github-xdg-stringprep-devel, golang-github-kr-pretty-devel, golang- github-cockroachdb-apd-devel, golang-github-alecthomas-chroma-devel, golang-github-alecthomas-kong-devel, golang-github-kr-text-devel, golang-github-containerd-console-devel, golang-github-datadog-devel, golang-github-hashicorp-consul-migrate-devel, golang-github-yunify- qingstor-sdk-devel, golang-github-oracle-oci-sdk-devel, golang-github- ulikunitz-xz-devel, golang-github-puerkitobio-urlesc-devel, golang- github-rasky-xdr-devel, golang-github-vitrun-qart-devel, golang- github-revel-pathtree-devel, golang-github-xeipuuv-gojsonpointer- devel, golang-github-hashicorp-net-rpc-msgpackrpc-devel, golang- github-golangplus-bytes-devel, golang-github-coreos-ioprogress-devel, golang-github-ishidawataru-sctp-devel, golang-github-daviddengcn- assert-devel, golang-github-alecthomas-colour-devel, golang-github- influxdata-tdigest-devel, golang-github-neelance-sourcemap-devel, golang-github-openapi-strfmt-devel, golang-github-revel-log15-devel, golang-github-exoscale-egoscale-devel, golang-github-schollz- progressbar-2-devel, golang-github-smartystreets-gunit-devel, golang- github-jackpal-gateway-devel, compat-golang-github-alexcesaro- quotedprintable-devel, golang-github-influxdata-influxdb-devel, golang-github-mjibson-appstats-devel, golang-github-hashicorp-mdns- devel, golang-github-nsf-termbox-devel, golang-github-nvveen-gotty- devel, golang-github-olekukonko-tablewriter-devel, compat-golang- github-tomb-devel, golang-github-pelletier-toml-devel, golang-github- vmware-photon-controller-sdk-devel, golang-github-hashicorp-memdb- devel, golang-github-shirou-gopsutil-devel, golang-github-vividcortex- mysqlerr-devel, golang-github-gorilla-schema-devel, golang-github- hashicorp-consul-devel, golang-github-sdboyer-constext-devel, compat- golang-github-aphistic-golf-devel, golang-github-goji-httpauth-devel, golang-github-streadway-amqp-devel, golang-github-glog-devel, golang- github-gocql-devel, golang-github-vishvananda-netlink-devel, golang- github-kr-logfmt-devel, golang-github-google-tspi-devel, golang- github-lightstep-tracer-devel, golang-github-mschoch-smat-devel, golang-github-kagami-avif-devel, golang-github-azure-ansiterm-devel, golang-github-uber-tally-devel, golang-github-racker-perigee-devel, golang-github-muesli-smartcrop-devel, golang-github-sergi-diff-devel, compat-golang-github-commonmark-html-devel, golang-github-jinzhu-now- devel, golang-github-ncw-swift-devel, golang-github-daviddengcn-villa- devel, golang-github-google-shlex-devel, golang-github-openapi-swag- devel, golang-github-flynn-json5-devel, golang-github- peterbourgon-g2s-devel, golang-github-rancher-devel, golang-github- docker-events-devel, golang-github-bouk-httprouter-devel, golang- github-gucumber-devel, golang-github-puerkitobio-purell-devel, golang- github-gin-contrib-sse-devel, golang-github-prometheus-common-devel, golang-github-bmizerany-pat-devel, golang-github-backtrace-labs-bcd- devel, golang-github-rackspace-gophercloud-devel, golang-github- influxdata-roaring-devel, golang-github-dgryski-bitstream-devel, golang-github-storageos-api-devel, golang-github-linuxdeepin- go-x11-client-devel, golang-github-rainycape-unidecode-devel, golang- github-petar-gollrb-devel, golang-github-google-certificate- transparency-devel, golang-github-rakyll-statik-devel, golang-github- alcortesm-tgz-devel, golang-github-syncthing-notify-devel, golang- github-cheekybits-genny-devel, golang-github-mdlayher-raw-devel, golang-github-skratchdot-open-devel, golang-github-eapache-resiliency- devel, golang-github-thomsonreuterseikon-ntlm-devel, golang-github- linuxdeepin-dbus-factory-devel, golang-github-tonistiigi-units-devel, golang-github-xlab-handysort-devel, golang-github-opencontainers-runc- devel, golang-github-hanwen-fuse-devel, golang-github-anacrolix- missinggo-devel, golang-github-containerd-runc-devel, golang-github- xorm-sqlfiddle-devel, golang-github-bradfitz-smtpd-devel, golang- github-gorilla-securecookie-devel, golang-github-skarademir- naturalsort-devel, golang-github-asaskevich-govalidator-devel, golang- github-lpabon-godbc-devel, golang-github-cosiner-argv-devel, golang- github-segmentio-kafka-devel, golang-github-vmware-govmomi-devel, golang-github-openzipkin-contrib-zipkin-opentracing-devel, golang- github-appc-goaci-devel, golang-github-nfnt-resize-devel, golang- github-cyphar-filepath-securejoin-devel, golang-github-macaron- binding-devel, golang-github-spacemonkeygo-openssl-devel, golang- github-gregjones-httpcache-devel, golang-github-minio-sha256-simd- devel, golang-github-bugsnag-devel, golang-github-burntsushi-xgb- devel, golang-github-hashicorp-memberlist-devel, golang-github- kisielk-gotool-devel, golang-github-gdamore-tcell-devel, golang- github-prometheus-procfs-devel, golang-github-google-cmp-devel, golang-github-tdewolff-test-devel, golang-github-howeyc-gopass-devel, golang-github-djherbis-buffer-devel, golang-github-dchest-siphash- devel, golang-github-influxdata-line-protocol-devel, golang-github- mitchellh-vnc-devel, golang-github-xiang90-probing-devel, golang- github-tchap-patricia-devel, golang-github-pierrec-lz4-devel, golang- github-rs-zerolog-devel, golang-github-jstemmer-gotags-devel, golang- github-aws-sdk-2-devel, golang-github-jawher-mow-cli-devel, golang- github-calmh-du-devel, golang-github-abourget-teamcity-devel, golang- github-cpuguy83-md2man-devel, golang-github-duosecurity-duo-api-devel, golang-github-masterminds-glide-devel, golang-github-coreos-gexpect- devel, golang-github-mholt-archiver-devel, golang-github-nytimes- gziphandler-devel, golang-github-thinkerou-favicon-devel, golang- github-j-keck-arping-devel, golang-github-docker-metrics-devel, golang-github-hailocab-hostpool-devel, golang-github-hashicorp-syslog- devel, golang-github-jacobsa-oglematchers-devel, golang-github- valyala-bytebufferpool-devel, compat-golang-github-asn1-ber-devel, golang-github-ryanuber-columnize-devel, golang-github-uber-jaeger-lib- devel, golang-github-sigma-inotify-devel, golang-github-masterminds- semver-1-devel, golang-github-prometheus-alertmanager-devel, golang- github-bgentry-speakeasy-devel, golang-github-alecthomas-assert-devel, golang-github-sendgrid-rest-devel, golang-github-keybase-crypto-devel, golang-github-cockroachdb-returncheck-devel, golang-github-jackc-fake- devel, compat-golang-github-redis-devel, golang-github-mitchellh- copystructure-devel, golang-github-facebookgo-clock-devel, golang- github-containerd-continuity-devel, golang-github-hashicorp-lru-devel, golang-github-soheilhy-cmux-devel, golang-github-tomasen-realip-devel, golang-github-akamai-akamaiopen-edgegrid-devel, C, golang-github- syndtr-goleveldb-devel, golang-github-alecthomas-repr-devel, golang- github-gomodule-redigo-devel, golang-github-facebookgo-stats-devel, golang-github-inconshreveable-vhost-devel, golang-github-gliderlabs- ssh-devel, golang-github-cespare-xxhash-devel, golang-github-logr- devel, golang-github-liggitt-tabwriter-devel, compat-golang-github- commonmark-mdurl-devel, golang-github-getsentry-raven-devel, golang- github-smartystreets-aws-auth-devel, golang-github-tcnksm-input-devel, golang-github-mattn-sqlite3-devel, golang-github-mvo5-uboot-devel, golang-github-beorn7-perks-devel, golang-github-coreos-oidc-devel, golang-github-inconshreveable-log15-devel, golang-github-spf13-afero- devel, golang-github-andy-kimball-arenaskl-devel, golang-github-mgutz- logxi-devel, golang-github-apache-thrift-devel, containerd-devel, golang-github-kr-pty-devel, golang-github-ajstarks-svgo-devel, golang- github-miekg-mmark-devel, golang-github-spacemonkeygo-flagfile-devel, golang-github-influxdata-influxdb1-client-devel, golang-github-fatih- set-devel, golang-github-opentracing-basictracer-devel, golang-github- stack-devel, golang-github-git-time-metric-gtm-devel, golang-github- mistifyio-zfs-devel, golang-github-streadway-handy-devel, golang- github-elazarl-bindata-assetfs-devel, golang-github-decker502-dnspod- devel, golang-github-gorilla-sessions-devel, golang-github- hydrogen18-stoppablelistener-devel, golang-github-jlaffaye-ftp-devel, golang-github-marstr-guid-devel, golang-github-shurcool-httpfs-devel, golang-github-urfave-cli-devel, golang-github-sethgrid-pester-devel, golang-github-modern-reflect2-devel, golang-github-naoina-stringutil- devel, golang-github-opentracing-contrib-observer-devel, golang- github-performancecopilot-speed-devel, golang-github-m3db-prometheus- client-devel, golang-github-euank-kmsg-parser-devel, golang-github- mitchellh-mapstructure-devel, golang-github-puerkitobio-goquery-devel, golang-github-cockroachdb-cmux-devel, golang-github-stretchr-testify- devel, golang-github-olekukonko-ts-devel, golang-github-knz-libedit- devel, golang-github-pelletier-buffruneio-devel, golang-github- dgryski-metro-devel, golang-github-hashicorp-gcp-common-devel, golang- github-kballard-shellquote-devel, golang-github-vividcortex-ewma- devel, golang-github-checkpoint-restore-criu-devel, golang-github- spacejam-loghisto-devel, golang-github-kimor79-gollectd-devel, golang- github-docker-libkv-devel, golang-github-google-flatbuffers-devel, golang-github-clbanning-x2j-devel, set, golang-github-google- querystring-devel, golang-github-miekg-pkcs11-devel, golang-github- jacobsa-ogletest-devel, golang-github-glacjay-goini-devel, golang- github-ghemawat-stream-devel, golang-github-macaron-inject-devel, golang-github-mitchellh-homedir-devel, golang-github-lucasb-eyer- colorful-devel, golang-github-shopify-toxiproxy-devel, golang-github- daviddengcn-algs-devel, golang-github-hashicorp-raft-mdb-devel, golang-github-bep-debounce-devel, golang-github-gorilla-handlers- devel, golang-github-karlseguin-expect-devel, to, golang-github-git- lfs-devel, golang-github-msteinert-pam-devel, golang-github- cockroachdb-circuitbreaker-devel, golang-github-montanaflynn-stats- devel, golang-github-containerd-btrfs-devel, golang-github-vmware- govcloudair-devel, golang-github-willf-bitset-devel, golang-github- circonus-labs-gometrics-devel, golang-github-fatih-camelcase-devel, golang-github-timewasted-linode-devel, golang-github-benesch- cgosymbolizer-devel, golang-github-chi-devel, golang-github-bkaradzic- lz4-devel, golang-github-paulbellamy-ratecounter-devel, golang-github- retailnext-hllpp-devel, golang-github-jmoiron-sqlx-devel, golang- github-gobuffalo-envy-devel, golang-github-boltdb-bolt-devel, golang- github-armon-consul-api-devel, golang-github-apache-arrow-devel, golang-github-certifi-gocertifi-devel, golang-github- fortytw2-leaktest-devel, golang-github-jdkato-prose-devel, golang- github-klauspost-compress-devel, golang-github-vividcortex-godaemon- devel, golang-github-roaringbitmap-roaring-devel, golang-github- docopt-devel, golang-github-gofrs-flock-devel, golang-github- spacemonkeygo-spacelog-devel, golang-github-xorm-builder-devel, golang-github-sstarcher-okta-devel, golang-github-thecodeteam- goscaleio-devel, golang-github-shogo82148-shuffle-devel, golang- github-spf13-cast-devel, golang-github-d2g-dhcp4server-devel, golang- github-jacobsa-oglemock-devel, golang-github-adroll-goamz-devel, golang-github-mattn-colorable-devel, golang-github-anacrolix-envpprof- devel, golang-github-circonus-labs-apiclient-devel, golang-github- marusama-semaphore-devel, golang-github-cloudflare-cfssl-devel, golang-github-nrdcg-goinwx-devel, golang-github-tonistiigi-immutable- radix-devel, golang-github-agl-ed25519-devel, golang-github-getkin- kin-openapi-devel, golang-github-ema-qdisc-devel, golang-github- simonpasquier-klog-gokit-devel, golang-github-logfmt-devel, golang- github-masterminds-vcs-devel, golang-github-urfave-negroni-devel, golang-github-zyedidia-clipboard-devel, golang-github-freetype-devel, golang-github-dnaeon-vcr-devel, golang-github-xdg-scram-devel, golang- github-geertjohan-rice-devel, golang-github-xeipuuv-gojsonschema- devel, golang-github-zenazn-goji-devel, golang-github-zyedidia- terminal-devel, golang-github-restic-chunker-devel, golang-github- twinj-uuid-devel, golang-github-bgentry-netrc-devel, golang-github- appc-spec-devel, golang-github-fsouza-dockerclient-devel, compat- golang-github-lint-devel, golang-github-danwakefield-fnmatch-devel, golang-github-coreos-semver-devel, golang-github-bugsnag-panicwrap- devel, golang-github-grpc-ecosystem-opentracing-devel, golang-github- imdario-mergo-devel, golang-github-marstr-goalias-devel, golang- github-prometheus-client-devel, golang-github-lucas-clemente- aes12-devel, compat-golang-github-mvdan-xurls-devel, golang-github- hashicorp-yamux-devel, golang-github-openapi-runtime-devel, golang- github-seandolphin-bqschema-devel, golang-github-google-btree-devel, golang-github-3rf-mongo-lint-devel, golang-github-census- instrumentation-opencensus-proto-devel, golang-github-cactus-statsd- client-devel, compat-golang-github-commonmark-puny-devel, golang- github-nats-io-streaming-server-devel, golang-github-graylog2-gelf- devel, golang-github-snappy-devel, golang-github-aymerick-douceur- devel, compat-golang-github-ini-devel, golang-github-casbin-devel, golang-github-klauspost-pgzip-devel, golang-github-microcosm-cc- bluemonday-devel, golang-github-djherbis-times-devel, golang-github- burntsushi-toml-test-devel, golang-github-gogo-protobuf-devel, golang- github-benbjohnson-clock-devel, golang-github-emirpasic-gods-devel, golang-github-knetic-govaluate-devel, golang-github-tdewolff-minify- devel, golang-github-cloudflare-redoctober-devel, golang-github- tdewolff-parse-devel, golang-github-prometheus-devel, golang-github- modern-concurrent-devel, golang-github-thejerf-suture-devel, golang- github-spf13-fsync-devel, golang-github-pengsrc-shared-devel, golang- github-pierrec-cmdflag-devel, golang-github-morikuni-aec-devel, golang-github-containerd-aufs-devel), /usr/share/gocode/src/github.com/nats-io(golang-github-nats-io-jwt- devel, golang-github-nats-io-nkeys-devel, golang-github-nats-io-nuid- devel, golang-github-nats-io-streaming-server-devel, golang-github- nats-io-streaming-devel, compat-golang-github-nats-io-server-devel, golang-github-nats-io-gnatsd-devel, C, golang-github-nats-io-devel, locale,, compat-golang-github-nats-io-devel, defaulting, Failed, set, to), /usr/share/gocode/src/github.com/nats-io/nats-server(compat- golang-github-nats-io-server-devel, C, locale,, defaulting, Failed, set, to), /usr/share/gocode/src/github.com/nats-io/nats-server/conf(C, locale,, defaulting, Failed, set, to), /usr/share/gocode/src/github.com/nats-io/nats-server/logger(C, locale,, defaulting, Failed, set, to), /usr/share/gocode/src/github.com/nats-io/nats-server/server(C, locale,, defaulting, Failed, set, to), /usr/share/gocode/src/github.com/nats-io/nats-server/server/pse(C, locale,, defaulting, Failed, set, to), /usr/share/gocode/src/github.com/nats-io/nats-server/test(C, locale,, defaulting, Failed, set, to), /usr/share/licenses/golang-github-nats- io-server-devel(C, locale,, defaulting, Failed, set, to), /usr/share/doc/golang-github-nats-io-server(C, locale,, defaulting, Failed, set, to), /usr/share/licenses/golang-github-nats-io-server(C, locale,, defaulting, Failed, set, to) [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 12 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang- github-nats-io-server-devel , compat-golang-github-nats-io-gnatsd- devel [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: golang-github-nats-io-server-2.0.2-1.fc31.x86_64.rpm golang-github-nats-io-server-devel-2.0.2-1.fc31.noarch.rpm compat-golang-github-nats-io-gnatsd-devel-2.0.2-1.fc31.noarch.rpm golang-github-nats-io-server-debuginfo-2.0.2-1.fc31.x86_64.rpm golang-github-nats-io-server-debugsource-2.0.2-1.fc31.x86_64.rpm golang-github-nats-io-server-2.0.2-1.fc31.src.rpm golang-github-nats-io-server.x86_64: W: no-manual-page-for-binary gnatsd golang-github-nats-io-server-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/nats-io/nats-server/.goipath compat-golang-github-nats-io-gnatsd-devel.noarch: W: obsolete-not-provided golang-github-nats-io-gnatsd-devel compat-golang-github-nats-io-gnatsd-devel.noarch: W: no-documentation compat-golang-github-nats-io-gnatsd-devel.noarch: W: dangling-relative-symlink /usr/share/gocode/src/github.com/nats-io/gnatsd nats-server 6 packages and 0 specfiles checked; 0 errors, 5 warnings. Rpmlint (debuginfo) ------------------- Checking: golang-github-nats-io-server-debuginfo-2.0.2-1.fc31.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). compat-golang-github-nats-io-gnatsd-devel.noarch: W: invalid-url URL: https://github.com/nats-io/nats-server <urlopen error [Errno -2] Name or service not known> compat-golang-github-nats-io-gnatsd-devel.noarch: W: obsolete-not-provided golang-github-nats-io-gnatsd-devel compat-golang-github-nats-io-gnatsd-devel.noarch: W: no-documentation compat-golang-github-nats-io-gnatsd-devel.noarch: W: dangling-relative-symlink /usr/share/gocode/src/github.com/nats-io/gnatsd nats-server golang-github-nats-io-server-debuginfo.x86_64: W: invalid-url URL: https://github.com/nats-io/nats-server <urlopen error [Errno -2] Name or service not known> golang-github-nats-io-server-debugsource.x86_64: W: invalid-url URL: https://github.com/nats-io/nats-server <urlopen error [Errno -2] Name or service not known> golang-github-nats-io-server.x86_64: W: invalid-url URL: https://github.com/nats-io/nats-server <urlopen error [Errno -2] Name or service not known> golang-github-nats-io-server.x86_64: W: no-manual-page-for-binary gnatsd golang-github-nats-io-server-devel.noarch: W: invalid-url URL: https://github.com/nats-io/nats-server <urlopen error [Errno -2] Name or service not known> golang-github-nats-io-server-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/nats-io/nats-server/.goipath 5 packages and 0 specfiles checked; 0 errors, 10 warnings. Source checksums ---------------- https://github.com/nats-io/nats-server/archive/v2.0.2/nats-server-2.0.2.tar.gz : CHECKSUM(SHA256) this package : 77e478cbf89a01e758d0016a34b6f8650d891cfb129d4de26d569093ab6f2430 CHECKSUM(SHA256) upstream package : 77e478cbf89a01e758d0016a34b6f8650d891cfb129d4de26d569093ab6f2430 Requires -------- golang-github-nats-io-server (rpmlib, GLIBC filtered): libc.so.6()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) golang-github-nats-io-server-devel (rpmlib, GLIBC filtered): go-filesystem golang(github.com/nats-io/jwt) golang(github.com/nats-io/nkeys) golang(golang.org/x/crypto/bcrypt) compat-golang-github-nats-io-gnatsd-devel (rpmlib, GLIBC filtered): go-filesystem golang-ipath(github.com/nats-io/nats-server) golang-github-nats-io-server-debuginfo (rpmlib, GLIBC filtered): golang-github-nats-io-server-debugsource (rpmlib, GLIBC filtered): Provides -------- golang-github-nats-io-server: golang-github-nats-io-server golang-github-nats-io-server(x86-64) golang-github-nats-io-server-devel: golang(github.com/nats-io/nats-server/conf) golang(github.com/nats-io/nats-server/logger) golang(github.com/nats-io/nats-server/server) golang(github.com/nats-io/nats-server/server/pse) golang(github.com/nats-io/nats-server/test) golang-github-nats-io-server-devel golang-ipath(github.com/nats-io/nats-server) compat-golang-github-nats-io-gnatsd-devel: compat-golang-github-nats-io-gnatsd-devel golang(github.com/nats-io/gnatsd/conf) golang(github.com/nats-io/gnatsd/logger) golang(github.com/nats-io/gnatsd/server) golang(github.com/nats-io/gnatsd/server/pse) golang(github.com/nats-io/gnatsd/test) golang-symlink(github.com/nats-io/gnatsd) golang-github-nats-io-server-debuginfo: debuginfo(build-id) golang-github-nats-io-server-debuginfo golang-github-nats-io-server-debuginfo(x86-64) golang-github-nats-io-server-debugsource: golang-github-nats-io-server-debugsource golang-github-nats-io-server-debugsource(x86-64) Generated by fedora-review 0.7.2 (65d36bb) last change: 2019-04-09 Command line :/usr/bin/fedora-review --rpm-spec -n golang-github-nats-io-server-2.0.2-1.fc31.src.rpm Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Perl, Ocaml, PHP, Python, C/C++, SugarActivity, Java, Haskell, R, fonts Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH ``` Thanks in advance, Hirotaka Wakabayashi -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
