https://bugzilla.redhat.com/show_bug.cgi?id=1737063 --- Comment #3 from Ben Rosser <rosser.bjr@xxxxxxxxx> --- > - Usually best to use --profile release with dune, to disable warnings. I think "dune build -p" sets profile=release automatically, according to the documentation. "--root . --only-packages PACKAGE --ignore-promoted-rules --no-config --profile release." > - Lines like %{_libdir}/ocaml/*/... are a bit strange (and unsafe). Probably best to use %{_libdir}/ocaml/%{libname}/... instead Good point! Fixed. > - Missing isa in -devel: > Requires: %{name}%{?_isa} = %{version}-%{release} Whoops, fixed. > - There seems to be a LICENSE file upstream. Is it missing from the tarball? > It should be added to the %license section if possible. > - Ask upstream to include the LICENSE file in their archive or include it directly as aSource1 I've just switched to the github tarball/tag snapshot, since that includes both the LICENSE and the tests (which I've now switched on in %check). Here's an updated spec. Let me know if there's anything else that needs changing: Spec URL: https://tc01.fedorapeople.org/ocaml/lwt/ocaml-mmap.spec SRPM URL: https://tc01.fedorapeople.org/ocaml/lwt/ocaml-mmap-1.1.0-2.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
