https://bugzilla.redhat.com/show_bug.cgi?id=1737063 Richard W.M. Jones <rjones@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rjones@xxxxxxxxxx --- Comment #1 from Richard W.M. Jones <rjones@xxxxxxxxxx> --- Some thoughts before the formal review: - Usually best to use --profile release with dune, to disable warnings. - There seems to be a LICENSE file upstream. Is it missing from the tarball? It should be added to the %license section if possible. - Lines like %{_libdir}/ocaml/*/... are a bit strange (and unsafe). Probably best to use %{_libdir}/ocaml/%{libname}/... instead -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
