https://bugzilla.redhat.com/show_bug.cgi?id=1735562 --- Comment #3 from Emmanuel Seyman <emmanuel@xxxxxxxxx> --- (In reply to Petr Pisar from comment #1) > > TODO: Either call make program by an absolute path, or do not call perl by > absolute path. This is inconsistent. > TODO: Use %{make_build} and %{make_install} macros instead of "make" and > "make pure_install". Using %{make_install} makes the build fail: https://koji.fedoraproject.org/koji/taskinfo?taskID=36738176 I went with "/usr/bin/make pure_install" and replaced "make" with %{make_build}. > TODO: Do not perform AUTHOR's tests. These are intended for maintainer only > are in fragile. FPC considers banning them. Ah, that's news to me. Removed. > FIX: Remove version constraint from perl-interpreter. The package has an > epoch and thus it does not make sense to use it that way. > TODO: Build-require 'perl(:VERSION) >= 5.8' (Makefile.PL:8). Done. > FIX: Constrain 'cmake-devel' dependency with '>= 0.21.0' (Makefile.PL:19). Done. > Please correct the 'FIX' items and consider fixing 'TODO' items before > building this package. Spec URL: http://people.parinux.org/~seyman/fedora/perl-CommonMark/perl-CommonMark.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-CommonMark/perl-CommonMark-0.290000-2.fc30.src.rpm > Resolution: Package APPROVED. Thank you for the review, Petr. Repo requested. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
