https://bugzilla.redhat.com/show_bug.cgi?id=1735762 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- make %{?_smp_mflags} → %make_build make install DESTDIR=%{buildroot} → %make_install - License seems to be MIT in the headers: https://github.com/brocade/bsn-fc-txptd/blob/master/fpin_main.c Not GPL. Please ask upstream for a separate license file - No: %dir /%{_sysdir}/systemd/system /%{_sysdir}/systemd/system/fctxpd.service Use: %{_unitdir}/fctxpd.service You also need to add the SystemD scriptlets, see https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#Systemd BuildRequires: systemd-rpm-macros […] %post %systemd_post fctxpd.service %preun %systemd_preun fctxpd.service %postun %systemd_postun_with_restart fctxpd.service - /sbin/fctxpd → %{_sbindir}/fctxpd -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
