Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: fedorainfinity-kdm-theme - Fedora Infinity KDM theme https://bugzilla.redhat.com/show_bug.cgi?id=313431 rdieter@xxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From rdieter@xxxxxxxxxxxx 2007-10-02 13:55 EST ------- A few picky SHOULDS: 1. using %find_lang. I don't see any included translations, so I'd suggest removing the extra bloat wrt %find_lang. 2. use %defattr(-, root, root, -) and MUST: 3. License: GPLv2 but missing %doc COPYING Otherwise, it's simple/clean, fix at item #3 (I'll trust you to do that). APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review