https://bugzilla.redhat.com/show_bug.cgi?id=1732894 --- Comment #14 from Fabio Valentini <decathorpe@xxxxxxxxx> --- A few comments outside the review template: 0. It looks like at least some of the included files are indeed licensed EPL (1.0 / 2.0), not BSD. Please make sure they're not shipped as part of the binary RPM, or adapt License tag accordingly and add a license file to the package with %license. 1. If git is a BR for tests, you could move it under %{with tests} as well. 2. "%package -n jgit-javadoc" -> "%package javadoc" (same for description), I guess this is a leftover from the eclipse-jgit packaging. 3. Do we need to build the source jar? otherwise, we can remove maven-source-plugin from the pom and BRs. 4. Why are failing tests ignored even when the build is run "--with tests"? 5. I think you could truncate the %changelog as well, since this is a new package. 6. Will eclipse-jgit have a versioned dependency on this package, to make sure they're updated at the same time? PS: Will splitting eclipse-jgit into two packages also solve the bootstrap issue in eclipse-jgit? Full review below. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [?]: License field in the package spec file matches the actual license. [?]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [?]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: jgit-5.4.0-3.fc31.noarch.rpm jgit-javadoc-5.4.0-3.fc31.noarch.rpm jgit-5.4.0-3.fc31.src.rpm jgit.noarch: E: explicit-lib-dependency jzlib jgit.noarch: W: name-repeated-in-summary C JGit jgit.noarch: W: no-manual-page-for-binary jgit jgit.src: W: name-repeated-in-summary C JGit jgit.src: W: invalid-url Source0: https://git.eclipse.org/c/jgit/jgit.git/snapshot/jgit-5.4.0.201906121030-r.tar.xz The read operation timed out 3 packages and 0 specfiles checked; 1 errors, 4 warnings. Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_GB.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_GB.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). jgit-javadoc.noarch: W: invalid-url URL: https://www.eclipse.org/jgit/ <urlopen error [Errno -2] Name or service not known> jgit.noarch: E: explicit-lib-dependency jzlib jgit.noarch: W: name-repeated-in-summary C JGit jgit.noarch: W: invalid-url URL: https://www.eclipse.org/jgit/ <urlopen error [Errno -2] Name or service not known> jgit.noarch: W: no-manual-page-for-binary jgit 2 packages and 0 specfiles checked; 1 errors, 4 warnings. Source checksums ---------------- https://git.eclipse.org/c/jgit/jgit.git/snapshot/jgit-5.4.0.201906121030-r.tar.xz : CHECKSUM(SHA256) this package : 8a3cb11479c6e47bf8fe49c09608c5be18c5da40d6d9dd08778dcbbdce104672 CHECKSUM(SHA256) upstream package : 8a3cb11479c6e47bf8fe49c09608c5be18c5da40d6d9dd08778dcbbdce104672 Requires -------- jgit (rpmlib, GLIBC filtered): /usr/bin/sh apache-sshd bouncycastle config(jgit) java-headless javapackages-filesystem jzlib mvn(args4j:args4j) mvn(com.google.code.gson:gson) mvn(com.googlecode.javaewah:JavaEWAH) mvn(com.jcraft:jsch) mvn(com.jcraft:jzlib) mvn(net.i2p.crypto:eddsa) mvn(org.apache.ant:ant) mvn(org.apache.commons:commons-compress) mvn(org.apache.httpcomponents:httpclient) mvn(org.apache.httpcomponents:httpcore) mvn(org.apache.sshd:sshd-osgi) mvn(org.apache.sshd:sshd-sftp) mvn(org.bouncycastle:bcpg-jdk15on) mvn(org.bouncycastle:bcpkix-jdk15on) mvn(org.bouncycastle:bcprov-jdk15on) mvn(org.eclipse.jetty:jetty-servlet) mvn(org.osgi:osgi.core) mvn(org.slf4j:slf4j-api) mvn(org.slf4j:slf4j-simple) jgit-javadoc (rpmlib, GLIBC filtered): javapackages-filesystem Provides -------- jgit: config(jgit) jgit mvn(org.eclipse.jgit:org.eclipse.jgit) mvn(org.eclipse.jgit:org.eclipse.jgit-parent:pom:) mvn(org.eclipse.jgit:org.eclipse.jgit.ant) mvn(org.eclipse.jgit:org.eclipse.jgit.ant:pom:) mvn(org.eclipse.jgit:org.eclipse.jgit.archive) mvn(org.eclipse.jgit:org.eclipse.jgit.archive:pom:) mvn(org.eclipse.jgit:org.eclipse.jgit.http.apache) mvn(org.eclipse.jgit:org.eclipse.jgit.http.apache:pom:) mvn(org.eclipse.jgit:org.eclipse.jgit.http.server) mvn(org.eclipse.jgit:org.eclipse.jgit.http.server:pom:) mvn(org.eclipse.jgit:org.eclipse.jgit.junit) mvn(org.eclipse.jgit:org.eclipse.jgit.junit.http) mvn(org.eclipse.jgit:org.eclipse.jgit.junit.http:pom:) mvn(org.eclipse.jgit:org.eclipse.jgit.junit.ssh) mvn(org.eclipse.jgit:org.eclipse.jgit.junit.ssh:pom:) mvn(org.eclipse.jgit:org.eclipse.jgit.junit:pom:) mvn(org.eclipse.jgit:org.eclipse.jgit.lfs) mvn(org.eclipse.jgit:org.eclipse.jgit.lfs.server) mvn(org.eclipse.jgit:org.eclipse.jgit.lfs.server:pom:) mvn(org.eclipse.jgit:org.eclipse.jgit.lfs:pom:) mvn(org.eclipse.jgit:org.eclipse.jgit.pgm) mvn(org.eclipse.jgit:org.eclipse.jgit.pgm:pom:) mvn(org.eclipse.jgit:org.eclipse.jgit.ssh.apache) mvn(org.eclipse.jgit:org.eclipse.jgit.ssh.apache:pom:) mvn(org.eclipse.jgit:org.eclipse.jgit.ui) mvn(org.eclipse.jgit:org.eclipse.jgit.ui:pom:) mvn(org.eclipse.jgit:org.eclipse.jgit:pom:) osgi(org.eclipse.jgit) osgi(org.eclipse.jgit.ant) osgi(org.eclipse.jgit.archive) osgi(org.eclipse.jgit.http.apache) osgi(org.eclipse.jgit.http.server) osgi(org.eclipse.jgit.junit) osgi(org.eclipse.jgit.junit.http) osgi(org.eclipse.jgit.junit.ssh) osgi(org.eclipse.jgit.lfs) osgi(org.eclipse.jgit.lfs.server) osgi(org.eclipse.jgit.pgm) osgi(org.eclipse.jgit.ssh.apache) osgi(org.eclipse.jgit.ui) jgit-javadoc: jgit-javadoc -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
