[Bug 1732735] Review Request: perl-Module-Build-Using-PkgConfig - Extend Module::Build to easily use platform libraries provided by pkg-config

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1732735

Petr Pisar <ppisar@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> ---
Url and Source0 addresses are Ok.
Source0 archive (SHA-256:
11774a6914bcfa0915f9f01c3041b16878d52ad86d83ecedbe62e68d4f41ecc1) is original.
Ok.
Summary is Ok.
Description verified from lib/Module/Build/Using/PkgConfig.pm. Ok.
License verified from lib/Module/Build/Using/PkgConfig.pm, LICENSE, and
Build.PL. Ok.
No XS code, noarch BuildArch is Ok.
Buildrequires are Ok.
All tests pass. Ok.

$ rpmlint perl-Module-Build-Using-PkgConfig.spec
../SRPMS/perl-Module-Build-Using-PkgConfig-0.03-1.fc31.src.rpm
../RPMS/noarch/perl-Module-Build-Using-PkgConfig-0.03-1.fc31.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

$ rpm -q -lv -p
../RPMS/noarch/perl-Module-Build-Using-PkgConfig-0.03-1.fc31.noarch.rpm 
drwxr-xr-x    2 root     root                        0 Jul 24 13:24
/usr/share/doc/perl-Module-Build-Using-PkgConfig
-rw-r--r--    1 root     root                      498 Apr 11 14:06
/usr/share/doc/perl-Module-Build-Using-PkgConfig/Changes
-rw-r--r--    1 root     root                     5704 Apr 11 14:06
/usr/share/doc/perl-Module-Build-Using-PkgConfig/README
drwxr-xr-x    2 root     root                        0 Jul 24 13:24
/usr/share/licenses/perl-Module-Build-Using-PkgConfig
-rw-r--r--    1 root     root                    18418 Apr 11 14:06
/usr/share/licenses/perl-Module-Build-Using-PkgConfig/LICENSE
-rw-r--r--    1 root     root                     3996 Jul 24 13:24
/usr/share/man/man3/Module::Build::Using::PkgConfig.3pm.gz
drwxr-xr-x    2 root     root                        0 Jul 24 13:24
/usr/share/perl5/vendor_perl/Module
drwxr-xr-x    2 root     root                        0 Jul 24 13:24
/usr/share/perl5/vendor_perl/Module/Build
drwxr-xr-x    2 root     root                        0 Jul 24 13:24
/usr/share/perl5/vendor_perl/Module/Build/Using
-rw-r--r--    1 root     root                    12808 Jul 24 13:24
/usr/share/perl5/vendor_perl/Module/Build/Using/PkgConfig.pm
File layout and permissions are Ok.

$ rpm -q --requires -p
../RPMS/noarch/perl-Module-Build-Using-PkgConfig-0.03-1.fc31.noarch.rpm | sort
-f | uniq -c
      1 perl(:MODULE_COMPAT_5.30.0)
      1 perl(:VERSION) >= 5.10.0
      1 perl(base)
      1 perl(ExtUtils::PkgConfig)
      1 perl(Module::Build)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsZstd) <= 5.4.18-1
Binary requires are Ok.

$ rpm -q --provides -p
../RPMS/noarch/perl-Module-Build-Using-PkgConfig-0.03-1.fc31.noarch.rpm | sort
-f | uniq -c
      1 perl(Module::Build::Using::PkgConfig) = 0.03
      1 perl-Module-Build-Using-PkgConfig = 0.03-1.fc31
Binary provides are Ok.

$ resolvedeps rawhide
../RPMS/noarch/perl-Module-Build-Using-PkgConfig-0.03-1.fc31.noarch.rpm 
Binary dependencies are resolvable. Ok.

The package builds in F31
(https://koji.fedoraproject.org/koji/taskinfo?taskID=36458530). Ok.

This package is in line with Fedora and Perl packaging guide lines.

Resolution: Package APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux