https://bugzilla.redhat.com/show_bug.cgi?id=1725924 --- Comment #19 from Steven Jay Munroe <munroesj52@xxxxxxxxx> --- - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ * pveclib.spec [BuildRequires]: Add gcc-c++. - ldconfig not called in %post and %postun for Fedora 28 and later. Note: /sbin/ldconfig called in pveclib See: https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets ^ No need for them now so they can be removed. [%post, %postun] Depreacted, removed Is COPYING the same as LICENSE? It should be in %license nevertheless. Yes but some older distros require/expect it and rpmlint did not like the symlink. So I duplicated LICENSE to COPYING. I have multiple masters here and trying keep them all happy. [%license]: Add COPYING. [%doc]: COPYING here too. - Sources used to build the package match the upstream source, as provided in the spec URL. not there yet working on it. Trying not the burn another version tag until we have this ready to go. - %configure is called twice---is that intentional? Noop, removed the dup. [?]: Package functions as described. ^ You'll have to check this Make check verifies this. Tested for -mcpu=power7/8/9 using gcc 6/7/8/9. Fedora tests are GCC9 -mcpu=power8 AutoTools: Obsoleted m4s found ------------------------------ AC_PROG_LIBTOOL found in: /home/asinha/dump/fedora-review/pveclib/review- pveclib/upstream-unpacked/Source0/pveclib-1.0.2/configure.ac:15 ^ Also worth checking and reporting upstream. I found not indication that is Obsoleted. Found and corrected 2 other cases. * configure.ac [AC_INIT] Bump version to 1.0.3 AC_CANONICAL_SYSTEM is deprecated, Replace with AC_CANONICAL_TARGET. AM_PROG_CC_C_O is deprecated, remove. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
