https://bugzilla.redhat.com/show_bug.cgi?id=1732311 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- Url and Source0 addresses are Ok. Source0 archive (SHA-256: 122877276af68032eb6d7f899ff4ec91c9e21380198fba73839b2e04ecd4ba63) is original. Ok. Summary is Ok. Description verified from lib/Test/NiceDump.pm. Ok. License verified from lib/Test/NiceDump.pm, Makefile.PL, README.md, and LICENSE. Ok. No XS code, noarch BuildArch is Ok. BuildRequires are Ok. TODO: Unset AUTHOR_TESTING environment variable in %check section to make the build reproducible (t/author-pod-coverage.t:4). All tests pass. Ok. $ rpmlint perl-Test-NiceDump.spec ../SRPMS/perl-Test-NiceDump-1.0.1-1.fc31.src.rpm ../RPMS/noarch/perl-Test-NiceDump-1.0.1-1.fc31.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Test-NiceDump-1.0.1-1.fc31.noarch.rpm drwxr-xr-x 2 root root 0 Jul 23 14:26 /usr/share/doc/perl-Test-NiceDump -rw-r--r-- 1 root root 298 Jul 17 16:53 /usr/share/doc/perl-Test-NiceDump/Changes -rw-r--r-- 1 root root 955 Jul 17 16:53 /usr/share/doc/perl-Test-NiceDump/README.md drwxr-xr-x 2 root root 0 Jul 23 14:26 /usr/share/licenses/perl-Test-NiceDump -rw-r--r-- 1 root root 18424 Jul 17 16:53 /usr/share/licenses/perl-Test-NiceDump/LICENSE -rw-r--r-- 1 root root 2641 Jul 23 14:26 /usr/share/man/man3/Test::NiceDump.3pm.gz drwxr-xr-x 2 root root 0 Jul 23 14:26 /usr/share/perl5/vendor_perl/Test -rw-r--r-- 1 root root 6033 Jul 17 16:53 /usr/share/perl5/vendor_perl/Test/NiceDump.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Test-NiceDump-1.0.1-1.fc31.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.30.0) 1 perl(Data::Dump) 1 perl(Data::Dump::Filtered) 1 perl(Exporter) 1 perl(overload) 1 perl(Safe::Isa) >= 1.000010 1 perl(strict) 1 perl(Test::Builder) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Test-NiceDump-1.0.1-1.fc31.noarch.rpm | sort -f | uniq -c 1 perl(Test::NiceDump) = 1.0.1 1 perl-Test-NiceDump = 1.0.1-1.fc31 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Test-NiceDump-1.0.1-1.fc31.noarch.rpm Binary dependencies are resolvable. Ok. The package builds in F31 (https://koji.fedoraproject.org/koji/taskinfo?taskID=36444787). Ok. The package is in line with Fedora and Perl packaging guide lines. Please consider fixing the 'TODO' item before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
