https://bugzilla.redhat.com/show_bug.cgi?id=1731583 --- Comment #4 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- (In reply to Timothée Floure from comment #3) > > Thanks for the quick review, Timothée. Please let me know if I can review something for you in return. :) > > Not right now but I'll keep it in mind. Thanks! > > > Yes. We want to support F29 too. > > A conditional and/or a comment would be nice so that an useless macro is not > forgotten for the next ten Fedora releases ;-) I've added a comment. It won't be forgotten, it already doesn't do anything in F30 and I'm sure it'll be mass-removed when it's not needed :) > > > A missing BR: pytest-cov. Added it now. I verified in a virtual environment > that all tests pass. I'll enable them as soon as pytest-sugar is approved. > > The pytest-cov issue is fixed but there is a failing test on my side, using > your python3-pytest-sugar package: > https://paste.sr.ht/~fnux/620bae68a1983798babcc943a726fc0f0d1c64aa Odd. I'm not getting it here in the virtual environment . Your error seems to be related to pandas but the version in Fedora is fine. I guess we can wait for python-pytest-sugar to be approved and then test it out with that. Testing it on local machines won't tell us the issue. $ pytest . Test session starts (platform: linux, Python 3.7.4, pytest 5.0.1, pytest-sugar 0.9.2) rootdir: /home/asinha/rpmbuild/SOURCES/pingouin-0.2.7, inifile: setup.cfg plugins: remotedata-0.3.1, travis-fold-1.3.0, sugar-0.9.2, cov-2.7.1 collecting ... pingouin/tests/test_bayesian.py ✓✓✓ 4% ▍ pingouin/tests/test_circular.py ✓✓✓✓✓✓✓ 13% █▍ pingouin/tests/test_contingency.py ✓✓✓✓ 18% █▊ pingouin/tests/test_correlation.py ✓✓✓✓ 23% ██▍ pingouin/tests/test_distribution.py ✓✓✓✓✓✓ 30% ███▏ pingouin/tests/test_effsize.py ✓✓✓✓✓ 37% ███▋ pingouin/tests/test_multicomp.py ✓✓✓✓ 42% ████▎ pingouin/tests/test_multivariate.py ✓✓ 44% ████▌ pingouin/tests/test_nonparametric.py ✓✓✓✓✓✓✓ 53% █████▍ pingouin/tests/test_pairwise.py ✓✓✓✓ 58% █████▉ pingouin/tests/test_pandas.py ✓ 59% █████▉ pingouin/tests/test_parametric.py ✓✓✓✓✓✓✓ 68% ██████▉ pingouin/tests/test_plotting.py ✓✓✓✓✓✓ 76% ███████▋ pingouin/tests/test_power.py ✓✓✓✓✓✓ 84% ████████▍ pingouin/tests/test_regression.py ✓✓✓ 87% ████████▊ pingouin/tests/test_reliability.py ✓✓ 90% █████████ pingouin/tests/test_utils.py ✓✓✓✓✓✓✓✓ 100% ██████████ ============================================================================================================== warnings summary ============================================================================================================== pingouin/tests/test_correlation.py::TestCorrelation::test_partial_corr /home/asinha/rpmbuild/SOURCES/pingouin-0.2.7/pingouin/utils.py:297: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working x_is_iter = isinstance(x, collections.Iterable) pingouin/tests/test_parametric.py::TestParametric::test_ancova /home/asinha/.local/share/virtualenvs/pingouin/lib/python3.7/site-packages/patsy/constraint.py:13: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working from collections import Mapping pingouin/tests/test_parametric.py::TestParametric::test_ancova /home/asinha/.local/share/virtualenvs/pingouin/lib64/python3.7/importlib/_bootstrap.py:219: RuntimeWarning: numpy.ufunc size changed, may indicate binary incompatibility. Expected 192 from C header, got 216 from PyObject return f(*args, **kwds) -- Docs: https://docs.pytest.org/en/latest/warnings.html ----------- coverage: platform linux, python 3.7.4-final-0 ----------- Name Stmts Miss Branch BrPart Cover Missing ----------------------------------------------------------------------- pingouin/__init__.py 19 0 0 0 100% pingouin/bayesian.py 67 0 16 0 100% pingouin/circular.py 86 0 20 0 100% pingouin/contingency.py 80 0 40 1 99% 351->354 pingouin/correlation.py 222 0 64 1 99% 80->79 pingouin/distribution.py 170 0 56 0 100% pingouin/effsize.py 174 0 82 1 99% 537->exit pingouin/multicomp.py 67 0 14 0 100% pingouin/multivariate.py 76 0 14 2 98% 87->93, 204->212 pingouin/nonparametric.py 121 1 20 1 99% 499, 498->499 pingouin/pairwise.py 276 0 140 0 100% pingouin/pandas.py 47 0 0 0 100% pingouin/parametric.py 419 0 101 2 99% 446->450, 892->896 pingouin/plotting.py 244 0 54 2 99% 466->470, 627->631 pingouin/power.py 240 0 112 0 100% pingouin/regression.py 205 0 76 0 100% pingouin/reliability.py 41 0 12 0 100% pingouin/utils.py 135 0 61 1 99% 162->174 ----------------------------------------------------------------------- TOTAL 2689 1 882 11 99% ========================================================================================================= slowest 10 test durations ========================================================================================================== 5.96s call pingouin/tests/test_regression.py::TestRegression::test_mediation_analysis 3.80s call pingouin/tests/test_pairwise.py::TestPairwise::test_pairwise_corr 3.34s call pingouin/tests/test_plotting.py::TestPlotting::test_plot_skipped_corr 1.42s call pingouin/tests/test_pairwise.py::TestPairwise::test_pairwise_ttests 1.08s call pingouin/tests/test_plotting.py::TestPlotting::test_plot_paired 1.00s call pingouin/tests/test_effsize.py::TestEffsize::test_compute_boot_esci 0.63s call pingouin/tests/test_parametric.py::TestParametric::test_ancova 0.59s call pingouin/tests/test_pandas.py::TestParametric::test_pandas 0.43s call pingouin/tests/test_correlation.py::TestCorrelation::test_corr 0.39s call pingouin/tests/test_plotting.py::TestPlotting::test_plot_shift Results (24.24s): 79 passed > > I believe you should remove `Documentation is available at > https://raphaelvallat.github.io/pingouin/build/html/index.html.` from the > description field: it is not relevant and the link is broken anyway. Removed too. Updated spec/srpm: Spec URL: https://ankursinha.fedorapeople.org/python-pingouin/python-pingouin.spec SRPM URL: https://ankursinha.fedorapeople.org/python-pingouin/python-pingouin-0.2.7-1.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
