https://bugzilla.redhat.com/show_bug.cgi?id=1709768 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #4 from Parag AN(पराग) <panemade@xxxxxxxxx> --- Sorry for being late to review this. Package Review ============== 1)[!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/xemacs/site- packages/lisp/site-start.d, /usr/share/xemacs/site-packages, /usr/share/xemacs, /usr/share/xemacs/site-packages/lisp You are missing below lines in spec at respective sub-packages section Requires: emacs-filesystem >= %{_emacs_version} Requires: xemacs-filesystem >= %{_xemacs_version} 2) Rpmlint ------- Checking: anthy-unicode-1.0.0.20190412-5.fc31.x86_64.rpm emacs-anthy-unicode-1.0.0.20190412-5.fc31.noarch.rpm xemacs-anthy-unicode-1.0.0.20190412-5.fc31.noarch.rpm anthy-unicode-devel-1.0.0.20190412-5.fc31.x86_64.rpm anthy-unicode-debuginfo-1.0.0.20190412-5.fc31.x86_64.rpm anthy-unicode-debugsource-1.0.0.20190412-5.fc31.x86_64.rpm anthy-unicode-1.0.0.20190412-5.fc31.src.rpm anthy-unicode.x86_64: W: spelling-error %description -l en_US emacs -> Emacs, macs, maces anthy-unicode.x86_64: W: shared-lib-calls-exit /usr/lib64/libanthydic-unicode.so.0.1.0 exit@GLIBC_2.2.5 anthy-unicode.x86_64: W: non-conffile-in-etc /etc/anthy-unicode.conf anthy-unicode.x86_64: W: no-manual-page-for-binary anthy-agent-unicode anthy-unicode.x86_64: W: no-manual-page-for-binary anthy-dic-tool-unicode anthy-unicode.x86_64: W: no-manual-page-for-binary anthy-morphological-analyzer-unicode emacs-anthy-unicode.noarch: W: spelling-error %description -l en_US elips -> plies, lips, slips emacs-anthy-unicode.noarch: E: description-line-too-long C This package contains the byte compiled elips packages to run anthy-unicode with GNU xemacs-anthy-unicode.noarch: W: spelling-error %description -l en_US elips -> plies, lips, slips anthy-unicode-debugsource.x86_64: W: invalid-url URL: https://github.com/fujiwarat/anthy-unicode/wiki The read operation timed out 7 packages and 0 specfiles checked; 1 errors, 9 warnings. => Fix the description of emacs-anthy-unicode to 80 chars per line Other than this, package looks good. APPROVED. You can import the fixed package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
