https://bugzilla.redhat.com/show_bug.cgi?id=1731568 --- Comment #2 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- Thanks for the review, Elliott, (In reply to Elliott Sales de Andrade from comment #1) > Some attempt to run tests is made in %check, but they are not actually run. Turns out the tests don't run with pytest >5, so I've disabled them for the time being. https://github.com/Frozenball/pytest-sugar/issues/180 > It is a bit odd that the dependencies are optionally not included as BRs, but > they are marked as runtime Requires, so they aren't exactly optional. They're picked up by the automatic generator, and are required for the tests so I'll leave them as conditional for the time beng also. > > Passing %{pypi_name} to %pypi_source is unnecessary. > The URL should be https://pypi.org/project/%{pypi_name} Corrected both of these. Thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
