https://bugzilla.redhat.com/show_bug.cgi?id=1731206 --- Comment #2 from Petr Viktorin <pviktori@xxxxxxxxxx> --- (In reply to Miro Hrončok from comment #1) > I see you are using pyproject-rpm-macros. The macros are provisional and > since you are one of the maintainers of them, I'd expect that you will > follow any API changes in them while maintaining this package. Since also `%pyproject_buildrequires -r` will need this, I hope the changes will be well coordinated :) > Also, given > that this package will be needed for the proper automatic generation of > BuildRequires, I don't htink this package shall be generating the > buildrequires dynamically ever. That might deserve a comment in spec, such > as "Don't ever use %%pyproject_buildrequires to avoid a build dependency > loop." +1, will add. > Package APPROVED. Thank you! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
