Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kbiof - KDE port of the original BIOF XScreenSaver https://bugzilla.redhat.com/show_bug.cgi?id=313211 fedora@xxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From fedora@xxxxxxxxxxxxxxxxxx 2007-10-02 06:50 EST ------- OK - Meets Packaging Guidelines. OK - Package named correctly NA - Patches named correctly No Patches OK - Spec file named correctly to match base OK - License is valid OK - Licence field matches package OK - Licence file installed if supplied OK - Spec file in American English OK - Source matches upstream (md5) dd9bf4afca5bdbb95b6ae4f5cbe515b7 NA - Locales use %find_lang No locales OK - %clean is present and correct OK - Package has correct buildroot. OK - Specfile Legible OK - Builds in Mock F&-i386 NA - %post/%postun calls ldconfig for sh libs No sh libs OK - Owns directories it creates OK - No duplicate files OK - Has %defattr and has correct permissions OK - Macros used consistantly OK - %doc does not affect runtime NA - Headers/static libs in -devel NA - .pc files in -devel NA - .so files in -devel NA - -devel requires base No devel OK - Contains no .la libtool archive files OK - Does not own others files OK - .desktop files installed correctly OK - BuildRequires correct. OK - Package is code or permissible content. OK - Package has rm -rf %{buildroot} at top of %install. OK - Package compiles and builds on at least one arch. F&-i386 OK - rpmlint output. 1 Warning as explained in review. NA - documentation in -doc package OK - final provides and requires are sane. OK - should have dist tag OK - should package latest version APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review