https://bugzilla.redhat.com/show_bug.cgi?id=1671790 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx Flags| |fedora-review+ --- Comment #33 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- Looks good now. Three minor things: - The version in the changelog entry should be adjusted to match - The description text shouldn't be duplicated. Use the following: %global _description %{expand: Miscellaneous utilities for dealing with filesystems, paths, projects, sub-processes, and more.} %description %_description ... %description -n python3-%{srcname} %_description - Move BuildRequires to the top. + package name is OK + license is acceptable (ISC) + license is specified correctly + normal python spec file template is used... Package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
