https://bugzilla.redhat.com/show_bug.cgi?id=1728307 Xavier Bachelot <xavier@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|POST |ASSIGNED Flags|fedora-review+ |fedora-review? --- Comment #10 from Xavier Bachelot <xavier@xxxxxxxxxxxx> --- (In reply to Robert-André Mauchin from comment #8) > LGTM, package approved. Thanks for the review. (In reply to Nicolas Mailhot from comment #9) > (In reply to Xavier Bachelot from comment #7) > > > - Drop commented out appstream support. > > Sorry about that, not wasting time on manual appstream files is perfectly > fine, they don't contain any info not already present in the rpm package, so > the next generation of font macros will just generate them (as it should > have been done in the first place) > > I really need to finish this and send it to FPC :( No worries, it was just a couple lines to remove, not a big deal and much easier than to grasp what the appstream support is all about. I'll save that for another time. Thanks for your help. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
