[Bug 1728307] Review Request: foundation-icons-fonts - Icons web font

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1728307



--- Comment #4 from Xavier Bachelot <xavier@xxxxxxxxxxxx> ---
Thanks for the review Robert-André.

And thanks for the comments Nicolas. As this is my very first font package and
I know next to nothing about fonts in general, please bear with me for any
stupid question :-)

So, practically speaking, I should only package the ttf font and remove all of
the others (eot, woff and svg).

And then I should patch the css file to remove references to eot, woff and svg.

The css currently contains this :
"""
@font-face {
  font-family: "foundation-icons";
  src: url("foundation-icons.eot");
  src: url("foundation-icons.eot?#iefix") format("embedded-opentype"),
       url("foundation-icons.woff") format("woff"),
       url("foundation-icons.ttf") format("truetype"),
       url("foundation-icons.svg#fontcustom") format("svg");
  font-weight: normal;
  font-style: normal;
}
"""

It should be rewritten to :
"""
@font-face {
  font-family: "foundation-icons";
  src: url("foundation-icons.ttf") format("truetype");
  font-weight: normal;
  font-style: normal;
}
"""

Is that correct ?

Then, as I'm packaging this font to unbundle it from another software that just
passed review (sympa mailing list manager, RHBZ#17283000), I shall convince
upstream to only keep the ttf version of the font and assure them this will not
break the WUI for any browser. Do you have any link to support this claim ? Or
shall https://caniuse.com/#feat=ttf be enough ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux