https://bugzilla.redhat.com/show_bug.cgi?id=1730111 --- Comment #4 from Vitaly Zaitsev <vitaly@xxxxxxxxxxxxxx> --- 1. As you use cmake, it would be better to replace all pkgconfig to cmake() where possible: BuildRequires: cmake(Qt5Svg) BuildRequires: cmake(Qt5DBus) BuildRequires: cmake(Qt5Core) BuildRequires: cmake(Qt5Widgets) BuildRequires: cmake(Qt5Network) BuildRequires: cmake(Qt5Multimedia) BuildRequires: cmake(Qt5Concurrent) BuildRequires: cmake(Qt5LinguistTools) > export AR=%{_bindir}/gcc-ar > export RANLIB=%{_bindir}/gcc-ranlib > export NM=%{_bindir}/gcc-nm 2. Now you don't need to export this manually. Use cmake options instead: %cmake \ -DCMAKE_AR=%{_bindir}/gcc-ar \ -DCMAKE_RANLIB=%{_bindir}/gcc-ranlib \ -DCMAKE_NM=%{_bindir}/gcc-nm \ .. > -DCMAKE_INSTALL_PREFIX=%{_prefix} 3. Already included to %cmake macro. 4. Please add AppData manifest and send it to upstream. > %files devel > %{_libdir}/libcorectrl.so Development package without any useful headers. Just remove %{_libdir}/libcorectrl.so symbolic link. > global optflags %{optflags} -flto > %global build_ldflags %{build_ldflags} -flto Cmake has built-in IPO feature. You can use it instead of changing build flags. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
