[Bug 1728300] Review Request: sympa - Powerful multilingual List Manager

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1728300



--- Comment #3 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
(In reply to Xavier Bachelot from comment #2)
> Thanks for the review.
> 
> (In reply to Robert-André Mauchin from comment #1)
> >  - Make a separate subpackage for the doc
> > 
> I've removed 2 big files which are not really relevant. This saves 5 MB.
> Also, I've created a devel-doc sub-package holding the internal perl modules
> documentation (all man3 files). This saves 624 KB.
> Does one still need the -doc then ?
> 
> 
It should be ok


> 
> > [x]: %config files are marked noreplace or the reason is justified.
> >      Note: No (noreplace) in %config(noreplace,missingok)
> >      %attr(-,sympa,sympa) /etc/sympa/auth.conf %config(noreplace,missingok)
> >      %attr(-,sympa,sympa) /etc/sympa/charset.conf
> >      %config(noreplace,missingok) %attr(-,sympa,sympa)
> >      /etc/sympa/crawlers_detection.conf %config(noreplace,missingok)
> >      %attr(-,sympa,sympa) /etc/sympa/create_list.conf
> >      %config(noreplace,missingok) %attr(-,sympa,sympa)
> >      /etc/sympa/edit_list.conf %config(noreplace,missingok)
> >      %attr(-,sympa,sympa) /etc/sympa/nrcpt_by_domain.conf
> >      %config(noreplace,missingok) %attr(-,sympa,sympa)
> >      /etc/sympa/topics.conf %config(noreplace,missingok)
> >      %attr(-,sympa,sympa) /etc/sympa/mime.types
> >      %config(noreplace,missingok) %attr(-,sympa,sympa)
> >      /etc/sympa/sympa.wsdl %config(missingok) %attr(-,sympa,sympa)
> >      /etc/sympa/data_structure.current_version
> 
> The files marked as %config(noreplace,missingok) are optional. An admin may
> want to remove them if he uses them un-modified from the defaults that live
> in 
> /usr/share/sympa/default.
> I'm confused with the 'No (noreplace) in %config(noreplace,missingok)'
> comment. Can you explain ? Or is that just rpmlint/fedora-review being picky
> ?
> If one or the other needs to be removed, I'd remove ignoremissing rather
> than noreplace.
> 

I think it's fedora-review messing up the detection of no replace. Safe to
ignore.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux