https://bugzilla.redhat.com/show_bug.cgi?id=1727181 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zebob.m@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |zebob.m@xxxxxxxxx Flags| |fedora-review+ --- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- You need to sign the CLA https://fedoraproject.org/wiki/Join_the_package_collection_maintainers?rd=PackageMaintainers/Join#Create_a_Fedora_Account and need to get sponsored too https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group - Group: is not used in Fedora - libspeexdsp.dll.a is included twice in both subpackages, remove the duplicates. Package approved. Please fix the aforementioned issues before import. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not contain duplicates in %files. Note: BUILDSTDERR: warning: File listed twice: /usr/i686-w64-mingw32/sys- root/mingw/lib/libspeexdsp.dll.a See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 3-clause "New" or "Revised" License", "*No copyright* BSD (unspecified)", "Expat License", "FSF Unlimited License (with Retention) GNU General Public License", "FSF Unlimited License (with Retention)". 98 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/mingw- speexdsp/review-mingw-speexdsp/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/i686-w64-mingw32/sys- root/mingw/share/doc/speexdsp, /usr/x86_64-w64-mingw32/sys- root/mingw/share/doc/speexdsp [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mingw32-speexdsp , mingw64-speexdsp [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: The placement of pkgconfig(.pc) files are correct. Note: mingw32-speexdsp : /usr/i686-w64-mingw32/sys- root/mingw/lib/pkgconfig/speexdsp.pc mingw64-speexdsp : /usr/x86_64-w64-mingw32/sys-root/mingw/lib/pkgconfig/speexdsp.pc [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: mingw32-speexdsp-1.2.0-1.fc31.noarch.rpm mingw64-speexdsp-1.2.0-1.fc31.noarch.rpm mingw-speexdsp-1.2.0-1.fc31.src.rpm mingw32-speexdsp.noarch: W: spelling-error %description -l en_US Speex -> Speer, Speed, Perspex mingw32-speexdsp.noarch: W: spelling-error %description -l en_US kbps -> bps, kips, k bps mingw32-speexdsp.noarch: W: no-documentation mingw32-speexdsp.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/speex/speex_echo.h mingw32-speexdsp.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/speex/speex_jitter.h mingw32-speexdsp.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/speex/speex_preprocess.h mingw32-speexdsp.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/speex/speex_resampler.h mingw32-speexdsp.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/speex/speexdsp_config_types.h mingw32-speexdsp.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/speex/speexdsp_types.h mingw32-speexdsp.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/lib/libspeexdsp.dll.a mingw32-speexdsp.noarch: W: spurious-executable-perm /usr/i686-w64-mingw32/sys-root/mingw/lib/libspeexdsp.dll.a mingw32-speexdsp.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/lib/pkgconfig/speexdsp.pc mingw32-speexdsp.noarch: W: non-standard-dir-in-usr i686-w64-mingw32 mingw64-speexdsp.noarch: W: spelling-error %description -l en_US Speex -> Speer, Speed, Perspex mingw64-speexdsp.noarch: W: spelling-error %description -l en_US kbps -> bps, kips, k bps mingw64-speexdsp.noarch: W: no-documentation mingw64-speexdsp.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/speex/speex_echo.h mingw64-speexdsp.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/speex/speex_jitter.h mingw64-speexdsp.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/speex/speex_preprocess.h mingw64-speexdsp.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/speex/speex_resampler.h mingw64-speexdsp.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/speex/speexdsp_config_types.h mingw64-speexdsp.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/speex/speexdsp_types.h mingw64-speexdsp.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/lib/libspeexdsp.dll.a mingw64-speexdsp.noarch: W: spurious-executable-perm /usr/x86_64-w64-mingw32/sys-root/mingw/lib/libspeexdsp.dll.a mingw64-speexdsp.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/lib/pkgconfig/speexdsp.pc mingw64-speexdsp.noarch: W: non-standard-dir-in-usr x86_64-w64-mingw32 mingw-speexdsp.src: W: spelling-error %description -l en_US Speex -> Speer, Speed, Perspex mingw-speexdsp.src: W: spelling-error %description -l en_US kbps -> bps, kips, k bps mingw-speexdsp.src: W: spelling-error %description -l en_US speex -> speed, perspex 3 packages and 0 specfiles checked; 0 errors, 29 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
