https://bugzilla.redhat.com/show_bug.cgi?id=1723575 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #5 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - Use a bcond_without for this %if 0%{?rhel} == 7 %bcond_without python2 %endif And then: %if %{with python2} blah blah %endif - Xour descriptions must be wrapped to 80 characters per line - Name should be: Name: python-%{pkgname} - Comments at the end of line are not supported officially by rpm: %endif # with_python2 This will fail with rpm 4.15 - Install the examples with %doc %files -n python%{python3_pkgversion}-%{pkgname} %doc examples - Build the docs with Sphinx and install them with %doc # generate html docs sphinx-build-3 docs html # remove the sphinx-build leftovers rm -rf html/.{doctrees,buildinfo} -Install the misc docs markdown files: %files -n python%{python3_pkgversion}-%{pkgname} %doc examples %doc CHANGELOG.md CONTRIBUTING.md README.rst - you *must* install the LICENSE file with %license in %files for any subpackage compination: %files -n python2-%{pkgname} %license LICENSE %files -n python%{python3_pkgversion}-%{pkgname} %license LICENSE - You are missing the Python provide macro: %package -n python2-%{pkgname} Summary: Data collection and processing framework %{?python_provide:%python_provide python2-%{pkgname}} %package -n python%{python3_pkgversion}-%{pkgname} Summary: Data collection and processing framework %{?python_provide:%python_provide python3-%{pkgname}} See https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_the_python_provide_macro - add a space between your name and email in you changelog entry -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
