https://bugzilla.redhat.com/show_bug.cgi?id=1723570 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #3 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- Source0: https://pypi.org/packages/source/f/filecache/%{name}-%{version}.zip → Source0: %{pypi_source} - No need for this, just set the version in the Version: field %global version 0.77 - No %global name filecache, name should be python-filecache %global srcname filecache Name: python-%{srcname} And replace your %{name} by %{srcname} throughout the SPEC - Put an effort in your Summaries and description. Describe what does it do and so on. Summary: Cache the return value of functions %description "filecache" is a decorator that saves the return values of a decorated function to a file. The cache lives even after the interpreter restarts. For example a function which downloads stuff and does heavy duty parsing can benefit from this package. All you need to do is specify how long the return values should be cached (use seconds, like time.sleep). - Python 2 is deprecated, please remove the Py 2 subpackage for Fedora. Add it behind a flag with bcond_with/bcond_without if you plan to make it for EPEL too. - You are missing the Pythonn provide macro: %package -n python%{python3_pkgversion}-%{srcname} Summary: Cache the return value of functions BuildRequires: python%{python3_pkgversion}-devel BuildRequires: python%{python3_pkgversion}-setuptools %{?python_provide:%python_provide python3-%{srcname}} See https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_the_python_provide_macro -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
