[Bug 1725924] Review Request: pveclib - Library for simplified access to PowerISA vector operations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1725924



--- Comment #13 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> ---
(In reply to Steven Jay Munroe from comment #12)
> Making progress on clean up of rpmlint issues:
> 
> Latest changes in pull request
> https://github.com/open-power-sdk/pveclib/pull/79 for review.
> 
> Current results:
> $ rpmlint ./rpmbuild/
> pveclib.ppc64le: W: spelling-error %description -l en_US altivec -> elective
> pveclib-devel.ppc64le: W: no-documentation
> pveclib.src: W: spelling-error %description -l en_US altivec -> elective
> 5 packages and 2 specfiles checked; 0 errors, 3 warnings.
> 
> Not sure is the no-documentation is a show stopper. Not sure what do as man
> files would be useless and generating PDF would add a lot more dependencies
> to the build.

If the man files are part of the source, they may be included. This isn't a
blocker.

> 
> Antonio:
> 
> I merged most of your suggestions except for:
> - The static libraries MUST be placed in a *-static sub-package.
> 
> The referenced doc tells me what but not how. I will need examples.

You define a new sub-package, like the devel package is defined, and add the
related files to the new files section. Here is an example package:

https://src.fedoraproject.org/rpms/klt/blob/master/f/klt.spec#_43

Could you please provide links to the new spec/srpm when you've made changes?
That way, we always run checks on the newest iterations and don't end up
pointing out issues that have already been fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux