https://bugzilla.redhat.com/show_bug.cgi?id=1726843 --- Comment #4 from David Moreau Simard <dms@xxxxxxxxxx> --- (In reply to Miro Hrončok from comment #3) > Various notes about the spec: > > Requires: python3-box > Requires: python3-click > Requires: python3-dotenv > Requires: python3-toml > Requires: python3-pyyaml > > Is the automatic dependency generator not useful here? Thanks, I removed the Requires and the automatic dependency generator works as intended. > > %{python3_sitelib}/%{srcname}-*.egg-info > > The setup.py has: > > try: > from setuptools import setup, find_packages > except ImportError: > from distutils.core import setup, find_packages > > I consider this combination quite dangerous, because based on the presence > of setuptools in the buildroot, either distutils or setuptools will be used > and %{python3_sitelib}/%{srcname}-*.egg-info will either be a file or > directory. Updates between those two are problematic, see > https://docs.fedoraproject.org/en-US/packaging-guidelines/ > Directory_Replacement/ > > As a precaution I suggest doing the following: > > 1) BuildRequire python3-setuptools explicitly > 2) add a trailing slash to %{python3_sitelib}/%{srcname}-*.egg-info/ -> > this will make sure the build fails if it is not a directory > 3) (optional) also add the slash to %{python3_sitelib}/%{srcname}/ for > consistency with 2) and better readability > Good catch. I've made the suggested adjustment and it builds fine. > Summary: dynaconf is a dynamic configurator for python projects > -> > Summary: Dynaconf is a dynamic configurator for Python projects Done > %global common_desc \ > dynaconf is a layered configuration system for Python applications with > strong \ > support for 12-factor applications and extensions for Flask and Django > -> > %global common_desc \ > Dynaconf is a layered configuration system for Python applications with > strong \ > support for 12-factor applications and extensions for Flask and Django. Done -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
