https://bugzilla.redhat.com/show_bug.cgi?id=1726432 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #5 from Petr Pisar <ppisar@xxxxxxxxxx> --- > TODO: Replace %__perl macro with plain perl command. The macro is an internal to rpm-build and actually will be removed from rpm-4.15. TODO: There is one occurrance left: Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) > FIX: Remove perl(Cwd), perl(CPANPLUS::Backend), perl(CPAN), perl(Config), perl(File::Spec), perl(vars). They are used only from inc/Module/AutoInstall.pm that is deleted in %prep section and never executed. FIX: perl(vars) is still there. $ rpmlint perl-Mojo-RabbitMQ-Client* perl-Mojo-RabbitMQ-Client.spec: W: invalid-url Source0: Mojo-RabbitMQ-Client-without-amqp0.8-spec-0.2.2.tar.gz perl-Mojo-RabbitMQ-Client.noarch: W: spelling-error Summary(en_US) IOLoop -> Io Loop, Io-loop, Loop perl-Mojo-RabbitMQ-Client.noarch: W: spelling-error %description -l en_US IOLoop -> Io Loop, Io-loop, Loop perl-Mojo-RabbitMQ-Client.src: W: spelling-error Summary(en_US) IOLoop -> Io Loop, Io-loop, Loop perl-Mojo-RabbitMQ-Client.src: W: spelling-error %description -l en_US IOLoop -> Io Loop, Io-loop, Loop perl-Mojo-RabbitMQ-Client.src: W: invalid-url Source0: Mojo-RabbitMQ-Client-without-amqp0.8-spec-0.2.2.tar.gz 2 packages and 1 specfiles checked; 0 errors, 6 warnings. rpmlint is Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Mojo-RabbitMQ-Client-0.2.2-3.fc31.noarch.rpm |sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.30.0) 1 perl(Carp) 1 perl(constant) 1 perl(File::Basename) 1 perl(File::ShareDir) 1 perl(List::Util) 1 perl(List::Util) >= 1.33 1 perl(Mojo::Base) 1 perl(Mojo::EventEmitter) 1 perl(Mojo::Home) 1 perl(Mojo::IOLoop) 1 perl(Mojo::JSON) 1 perl(Mojo::Parameters) 1 perl(Mojo::Promise) 1 perl(Mojo::RabbitMQ::Client) 1 perl(Mojo::RabbitMQ::Client::Channel) 1 perl(Mojo::RabbitMQ::Client::Consumer) 1 perl(Mojo::RabbitMQ::Client::LocalQueue) 1 perl(Mojo::RabbitMQ::Client::Method) 1 perl(Mojo::RabbitMQ::Client::Method::Publish) 1 perl(Mojo::RabbitMQ::Client::Publisher) 1 perl(Mojo::URL) 1 perl(Mojo::Util) 1 perl(Net::AMQP) 1 perl(Net::AMQP) >= 0.06 1 perl(Net::AMQP::Common) 1 perl(Scalar::Util) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 TODO: Filter unversioned dependencies 'perl(List::Util)', and 'perl(Net::AMQP)'. The package builds in F31 (https://koji.fedoraproject.org/koji/taskinfo?taskID=36127171). Ok. Please correct the 'FIX' item and consider fixing the 'TODO' items before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
