https://bugzilla.redhat.com/show_bug.cgi?id=1723013 Artur Iwicki <fedora@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxx --- Comment #6 from Artur Iwicki <fedora@xxxxxxxxxx> --- >Version: master >Release: 1.0%{?dist} You should use the upstream version number (1.0.0) and include snapshot info in the Release field. See the Versioning Guidelines: https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/ >Source0: https://github.com/mne-tools/mne-cpp/archive/master.zip Related to the point above - you should explicitly name a specific commit here. "master.zip" is a moving target. >curl -s https://raw.githubusercontent.com/jcfr/qt-easy-build/5.10.0/Build-qt.sh -o Build-qt.sh This will fail since official package builds are done with disabled Internet access. Everything that's needed for building the package should be listed in Source: and Patch: tags. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
