Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: vixie-cron https://bugzilla.redhat.com/show_bug.cgi?id=226529 ------- Additional Comments From pertusus@xxxxxxx 2007-10-01 15:39 EST ------- I suggest using the %bcond_with/%bcond_without macros. The autotools calls are unuseful now. RPM_OPT_FLAGS="$RPM_OPT_FLAGS -DLINT -Dlint" also is unused. The Url: is missing. You have forked ISC/BSD vixie cron. Now others, including other distros should also use the fork such that it becomes upstream vixie-cron. Did you contact the distros? Also did you advertise the fork on the relevant sites, like freshmeat? We really don't want to have a fedora/redhat only package. This is for upstream cron, but i say it here, since upstream is you: * You should replace the COPYING file with a file stating the license of most of the file, a MIT license. There is also a 2 clause BSD for popen.c. * You should reuse the doc/README file and remove what is said below To use this:... and replace with something relevant. Also change the url. You should also state clearly what you took as starting point. * you should move THANKS from doc/ to top directory. * the doc/FEATURES files should certainly be in the top directory. * in ChangeLog, the reference should certainly be to doc/CHANGES and not simply doc. Also there is a reference to a spec file, but no spec file. * In Makefile.am automake conditionals should be used to add conditionally the -lpam, -lselinux... Those conditionals should be set in configure.ac. * --with-etcdir seems strange to me. There is already sysconfdir? * selinux could be set in the default case on linux, but there should be a AC_ARG_WITH in linux too. Moreover it would be much better to have something like what is done for pam, that is autodetection of selinux libs. * also the audit stuff should be detected, not set unconditionally. * the unconditional AC_DEFINE are very strange. Either they should be in a header file, or a --enable-... should be added? * Use of AC_PREFIX_DEFAULT(/usr) is not a good idea in my opinion. Just leave it to autoconf. Same for CFLAGS and LDFLAGS. At least if you want to set LDFLAGS, verify that it is empty. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review