https://bugzilla.redhat.com/show_bug.cgi?id=1725924 Antonio Trande <anto.trande@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW CC| |anto.trande@xxxxxxxxx --- Comment #6 from Antonio Trande <anto.trande@xxxxxxxxx> --- - Use built-in macros as much as possible (https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros): '%setup -q -n %{name}-%{version}' --> %autosetup 'make %{?_smp_mflags}' --> %make_build 'make install DESTDIR=$RPM_BUILD_ROOT' --> %make_install 'rm -rf %{buildroot}/usr/share/doc/libpvec/ChangeLog.md' --> rm -rf %{buildroot}%{_datadir}/doc/libpvec/ChangeLog.md - Move %check section after the %install one - Is it needed to re-run %configure in %check? - The static libraries MUST be placed in a *-static sub-package. (https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_static_libraries) - The lines %dir %{_includedir}/pveclib %{_includedir}/pveclib/vec_common_ppc.h %{_includedir}/pveclib/vec_f128_ppc.h %{_includedir}/pveclib/vec_f64_ppc.h %{_includedir}/pveclib/vec_f32_ppc.h %{_includedir}/pveclib/vec_int128_ppc.h %{_includedir}/pveclib/vec_int64_ppc.h %{_includedir}/pveclib/vec_int32_ppc.h %{_includedir}/pveclib/vec_int16_ppc.h %{_includedir}/pveclib/vec_char_ppc.h %{_includedir}/pveclib/vec_bcd_ppc.h can be condensed with %{_includedir}/pveclib/ - The line '%{!?_licensedir:%global license %%doc}' is useless -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
