https://bugzilla.redhat.com/show_bug.cgi?id=1725497 --- Comment #3 from Hans de Goede <hdegoede@xxxxxxxxxx> --- Thank you for the quick review! (In reply to Miro Hrončok from comment #1) > You can probably replace make %{?_smp_mflags} with %make_build. Ack, will fix before import. > One BuildRequire per line makes it easier for git diffs and blames, etc.. > (however if you prefer multiple, that's fine). > > Based on the recent unannounced bumps, you should probably not use > %{_libdir}/*.so.* in %files (however, if this is dead upstream, it is > probably fine). Good point, I will make this versioned. > That said, are we OK with packaging dead upstream? This does not parse external data, so no security risk AFAICT, other then that it is plain C so easy (for me) to maintain and not breaking all the time because of a changing language specification. It is as much "finished" as it is "dead" really and some of the keyboards which need this lib are still being sold, so IMHO it is good to have this in Fedora. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
