https://bugzilla.redhat.com/show_bug.cgi?id=1724111 --- Comment #4 from Vitaly Zaitsev <vitaly@xxxxxxxxxxxxxx> --- 1. License: LGPLv3+ and zlib. 2. Unversioned so-files in %_libdir: /usr/lib64/lsp-plugins-jack-core-1.1.9.so. You need to set it's SONAME and SOVERSION like lsp-plugins-jack-core.so.1.1.9 or move it outside of %_libdir root. 3. Plugins-doc subpackage should be noarch. 4. Directories in packages are owned also by: /usr/lib64/lv2(lv2-carla, lv2), /usr/lib64/vst(Carla-vst), /usr/lib64/ladspa(ladspa). Please fix this by adding this packages as Requires and globing removal. 5. Do not use hardcoded paths. Replace PREFIX=/usr as PREFIX=%{_prefix}. 6. You must patch makefile to respect Fedora build flags. 7. Enable verbose makefile output. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
