https://bugzilla.redhat.com/show_bug.cgi?id=1723105 Elliott Sales de Andrade <quantum.analyst@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |quantum.analyst@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |quantum.analyst@xxxxxxxxx Flags| |fedora-review+ --- Comment #1 from Elliott Sales de Andrade <quantum.analyst@xxxxxxxxx> --- The golang.org/x/net/context -> context is not exactly about un-vendoring, but rather that context was subsumed in the Go standard library in Go 1.7 (yes, this package is old.) Remove "A " from Summary. It's also a bit long. Please fix on import. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. Licenses found: "Unknown or generated", "*No copyright* Apache License (v2.0)", "Apache License (v2.0)". 17 files have unknown license. Detailed output of licensecheck in 1723105-golang-github-jacobsa-oglemock/licensecheck.txt [x]: Package does not own files or directories owned by other packages. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Macros in Summary, %description expandable at SRPM build time. Note: Macros in: golang-github-jacobsa-oglemock (description) [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [?]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: golang-github-jacobsa-oglemock-0-0.1.20190622gite94d794.fc31~bootstrap.x86_64.rpm golang-github-jacobsa-oglemock-0-0.1.20190622gite94d794.fc31~bootstrap.src.rpm golang-github-jacobsa-oglemock.x86_64: W: spelling-error %description -l en_US matchers -> marchers, matches, catchers golang-github-jacobsa-oglemock.x86_64: W: spelling-error %description -l en_US oglematchers -> dogcatchers golang-github-jacobsa-oglemock.x86_64: W: spelling-error %description -l en_US ogletest -> ogle test, ogle-test, completest golang-github-jacobsa-oglemock.x86_64: W: incoherent-version-in-changelog 0-0.1.20190622gite94d794 ['0-0.1.20190622gite94d794.fc31~bootstrap', '0-0.1.20190622gite94d794.fc31~bootstrap'] golang-github-jacobsa-oglemock.x86_64: W: no-manual-page-for-binary createmock golang-github-jacobsa-oglemock.src: W: spelling-error %description -l en_US matchers -> marchers, matches, catchers golang-github-jacobsa-oglemock.src: W: spelling-error %description -l en_US oglematchers -> dogcatchers golang-github-jacobsa-oglemock.src: W: spelling-error %description -l en_US ogletest -> ogle test, ogle-test, completest golang-github-jacobsa-oglemock.src: E: specfile-error warning: -u use in %forgemeta is deprecated, use -z instead to select a separate set of rpm variables! 2 packages and 0 specfiles checked; 1 errors, 8 warnings. Rpmlint (debuginfo) ------------------- Checking: golang-github-jacobsa-oglemock-debuginfo-0-0.1.20190622gite94d794.fc31~bootstrap.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://github.com/jacobsa/oglemock/archive/e94d794d06ffc6de42cb19d0dab3c219efdd6dcf/oglemock-e94d794d06ffc6de42cb19d0dab3c219efdd6dcf.tar.gz : CHECKSUM(SHA256) this package : b14e3061b02e5e021f1ddfe648f244e64bcdcae4dbda2f874c97b34f5e91c787 CHECKSUM(SHA256) upstream package : b14e3061b02e5e021f1ddfe648f244e64bcdcae4dbda2f874c97b34f5e91c787 Requires -------- golang-github-jacobsa-oglemock (rpmlib, GLIBC filtered): libc.so.6()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) Provides -------- golang-github-jacobsa-oglemock: golang-github-jacobsa-oglemock golang-github-jacobsa-oglemock(x86-64) Generated by fedora-review 0.7.2 (65d36bb) last change: 2019-04-09 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1723105 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: Python, SugarActivity, Haskell, R, Perl, fonts, PHP, Java, C/C++, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
