https://bugzilla.redhat.com/show_bug.cgi?id=1668010 --- Comment #16 from Felix Schwarz <fschwarz@xxxxxxxxxxxxxxxxx> --- > I decided to add back the static library in its own sub-package. I don't want to remove the -use-staticlib option, because it seems like it might cause us problems in the future if fedora is missing on option supported by upstream. Agreed. However I think you forgot to add a dependency. Output when building rocblas: -- Found PkgConfig: /usr/bin/pkg-config (found version "1.6.1") CMake Error at /usr/lib64/cmake/hip/hip-targets.cmake:95 (message): The imported target "hip::hip_hcc_static" references the file "/usr/lib64/libhip_hcc_static.a" but this file does not exist. Possible reasons include: So I think hip-runtime-devel (which owns hip-targets.cmake) should also depend on hip-runtime-static. @Robert-André: Do you think the current solution with the static subpackage + hard dependency from hip-runtime-devel is ok? As far as I can tell this package seems to be fine so I'm willing to approve that package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
