https://bugzilla.redhat.com/show_bug.cgi?id=1703381 --- Comment #2 from Lubomir Rintel <lkundrak@xxxxx> --- Thanks for the review: (In reply to Robert-André Mauchin from comment #1) > - Just rm the *.la in install instead of: > > %exclude %{_libdir}/libdrm_armada.la > > find %{buildroot} -name '*.la' -print -delete Why? It just seems more complex for no apparent benefit. > - Group: is not used in Fedora Will fix. > - 20180720: should be the date you *took* the snapshot, not the date of the > commit Why? It doesn't make much sense to me and the guidelines don't seem to suggest anything like that: https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots > - How do you know the version is 2.0.0? Seems to be 2.0.3 from the Debian > changelog. That's what the configure.ac (and thus "make dist") uses. I guess you're right and the debian/changelog is more relevant. However, this would probably be a post-2.0.2 & pre-2.0.3 shapshot, since entries get added to 2.0.3 entry. > - Remove the dot at the end of summary: > > libdrm-armada-devel.x86_64: W: summary-ended-with-dot C Development files > for libdrm-armada. Will fix. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
