https://bugzilla.redhat.com/show_bug.cgi?id=1704522 Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ |needinfo?(dominik@greysecto | |r.net) | --- Comment #5 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> --- 1. The manpage is dungeon(6) while the binary is called "zork". This makes the manpage not discoverable easily. Please rename or at least add a link: %install ... echo ".so dungeon.6" > %{buildroot}%{_mandir}/man6/zork.6 %files ... %{_mandir}/man6/zork.6* 2. There are tons of warnings from gcc in the build log. Some of them look serious: https://copr-be.cloud.fedoraproject.org/results/jflory7/zork/fedora-rawhide-x86_64/00898454-zork/build.log.gz ... BUILDSTDERR: np.c:176:5: warning: array subscript -1 is outside array bounds of 'integer[40]' {aka 'int[40]'} [-Warray-bounds] BUILDSTDERR: 176 | --outbuf; BUILDSTDERR: | ^~~~~~~~ Please work with upstream to fix these. 3. The 'history' file could also be included as %doc. I missed that last time. Apart from that, it looks good packaging-wise and is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
