https://bugzilla.redhat.com/show_bug.cgi?id=1720377 Debarshi Ray <debarshir@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from Debarshi Ray <debarshir@xxxxxxxxxx> --- Great! Thanks for updating the package. Maybe you could expand the %description a bit to match up against runc, etc..? Not a blocker, though. There's this one rpmlint error, but it might be a false positive, and I will leave it to your judgement. $ rpmlint -i /home/rishi/devel/rpmbuild/RPMS/x86_64/crun-0.6-1.fc29.x86_64.rpm crun.x86_64: E: missing-call-to-chdir-with-chroot /usr/bin/crun This executable appears to call chroot without using chdir to change the current directory. This is likely an error and permits an attacker to break out of the chroot by using fchdir. While that's not always a security issue, this has to be checked. 1 packages and 0 specfiles checked; 1 errors, 0 warnings. Again, not a blocker, and you can suppress it in Taskotron tests run by Bodhi by adding a crun.rpmlintrc file: https://fedoraproject.org/wiki/Taskotron/Tasks/dist.rpmlint ACCEPTED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
