Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libpano13 - Library for manipulating panoramic images https://bugzilla.redhat.com/show_bug.cgi?id=253909 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review? ------- Additional Comments From panemade@xxxxxxxxx 2007-09-30 23:27 EST ------- (In reply to comment #3) > (In reply to comment #2) > > > 1) Good to use following syntax in SPEC > > Requires: %{name} = %{version}-%{release} for -devel and -tools sub packages. > > Fine, done. > > > 2) Use make %{?_smp_mflags} > > Should be ok, though I can't test it, done. > > > 3)Change %defattr(-,root,root) to %defattr(-,root,root,-) for all %files sections. > > Ok, can't find where this extra field is described, but it seems to be common > enough, done. You can find more info on this at http://docs.fedoraproject.org/developers-guide/ch-rpm-building.html > > New SPEC and SRPM: > http://fedorapeople.org/~bpostle/reviews/libpano13/libpano13.spec > http://fedorapeople.org/~bpostle/reviews/libpano13/libpano13-2.9.12-4.fc7.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review