[Bug 1721564] Review Request: rust-zincati - Update agent for Fedora CoreOS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1721564



--- Comment #8 from Robert Fairley <rfairley@xxxxxxxxxx> ---
(In reply to Robert-André Mauchin from comment #7)
> %{__install}, %{__mkdir_p} are not useful macros, use install and mkdir -p.
> As a general rule any macro starting with two underscores are for rpm
> private use, not public use.

Thanks, will keep this in mind for next time (just saw the fedora-devel thread
on this from earlier).

I updated the specfile and SRPM:

New specfile:
https://rfairley.fedorapeople.org/package-review/rust-zincati-03/rust-zincati.spec
New SRPM:
https://rfairley.fedorapeople.org/package-review/rust-zincati-03/rust-zincati-0.0.1-1.fc31.src.rpm

Specfile diff:
https://gist.github.com/rfairley/9b46cca7c5cf00cda6560a670c3aeeaf#gistcomment-2948589
Updated Kojo scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=35636349

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux