Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tempest - An OpenGL screensaver for KDE https://bugzilla.redhat.com/show_bug.cgi?id=313371 fedora@xxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From fedora@xxxxxxxxxxxxxxxxxx 2007-09-30 23:20 EST ------- OK - Meets Packaging Guidelines. OK - Package named correctly OK - Patches named correctly OK - Spec file named correctly to match base OK - License is valid OK - Licence field matches package OK *1 Licence file installed if supplied Not supplied OK - Spec file in American English OK - Source matches upstream (md5) bf04f2beb07b227a3e91536c5dbdb872 NA - Locales use %find_lang No locales OK - %clean is present and correct OK - Package has correct buildroot. OK - Specfile Legible OK - Builds in Mock F7-i386 NA - %post/%postun calls ldconfig for sh libs No libs NA - Owns directories it creates Does not create any directories OK - No duplicate files OK - Has %defattr and has correct permissions OK - Macros used consistantly NA - %doc does not affect runtime No documentation NA - Headers/static libs in -devel NA - .pc files in -devel NA - .so files in -devel NA - -devel requires base No devel files OK - Contains no .la libtool archive files OK - Does not own others files OK - .desktop files installed correctly OK - BuildRequires correct. OK - Package is code or permissible content. OK - Package has rm -rf %{buildroot} at top of %install. OK - Package compiles and builds on at least one arch. F7-i386 OK - rpmlint output. W: no-documentation, ok as there is no documentation. NA - documentation in -doc package No documentation OK - final provides and requires are sane. OK - should have dist tag OK *1 should package latest version Upstream does not have version info, date used. Screensaver installs and works as expected (looks great too). *1 Should consider contacting upstream regarding including License text in release and to ask them to consider using a version number. That being said, *APPROVED* -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review