https://bugzilla.redhat.com/show_bug.cgi?id=1721564 --- Comment #6 from Robert Fairley <rfairley@xxxxxxxxxx> --- Thanks for the review! I have updated the specfile and SRPM. Updated specfile: https://rfairley.fedorapeople.org/package-review/rust-zincati-02/rust-zincati.spec Updated SRPM: https://rfairley.fedorapeople.org/package-review/rust-zincati-02/rust-zincati-0.0.1-1.fc31.src.rpm Diff of the specfile changes: https://gist.github.com/rfairley/9b46cca7c5cf00cda6560a670c3aeeaf Updated Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=35633106 Also tested installation in an FCOS build - the `zincati` binary and the files are installed correctly. rpmlint shows the following: ``` # rpmlint rust-zincati.spec rust-zincati.spec:38: E: hardcoded-library-path in %{_prefix}/lib/%{crate}/config.d rust-zincati.spec:39: E: hardcoded-library-path in %{_prefix}/lib/%{crate}/config.d/50-fedora-coreos-cincinnati.toml rust-zincati.spec:67: E: hardcoded-library-path in %{_prefix}/lib/%{crate}/config.d cat: 50-zincati.conf: No such file or directory 0 packages and 1 specfiles checked; 3 errors, 0 warnings. ``` However `50-zincati.conf` is installed where it should: ``` $ rpm -qf /usr/lib/sysusers.d/50-zincati.conf zincati-0.0.1-1.fc31.x86_64 ``` For the library paths, these must be under `/usr/lib/zincati/config.d` as `zincati` reads configs from there, and I didn't see a macro that enforces `/usr/lib` listed here [1], however can change it if there is one. If this looks good, I can request an SCM repo. [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/RPMMacros/#_macros_for_paths_set_and_used_by_build_systems -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
