https://bugzilla.redhat.com/show_bug.cgi?id=1721157 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #2 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - Use https: URL: https://github.com/benzea/gnome-network-displays - Appdata files must be installed in %{_metainfodir} (/usr/share/metainfo) /usr/share/appdata is deprecated. %{_metainfodir}/org.gnome.NetworkDisplays.appdata.xml See PR https://github.com/benzea/gnome-network-displays/pull/39 - License file must be installed with %license, not %doc %license COPYING - You must verify the .desktop file with desktop-file-validate: BuildRequires: desktop-file-utils […] desktop-file-validate %{buildroot}/%{_datadir}/applications/*.desktop See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_file_install_usage - You must verify the Appdata file with appstream-util: BuildRequires: libappstream-glib […] appstream-util validate-relax --nonet %{buildroot}%{_metainfodir}/*.appdata.xml See https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/#_app_data_validate_usage - The license seems to be GPLv3 not GPLv2+ - If you install icons in %{_datadir}/icons/hicolor you mist Requires: hicolor-icon-theme to own the icons directories - Be more specific than %{_datadir}/icons/* -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
