Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: londonlaw - Online multiplayer version of a well known detective boardgame https://bugzilla.redhat.com/show_bug.cgi?id=302091 ------- Additional Comments From packages@xxxxxxxxxxxxxxxxxx 2007-09-30 18:29 EST ------- * rpmlint: No Problems * Package named correctly: Yes * Patches named correctly: Yes * Spec file named correctly: Yes * Licence(s) acceptable: Yes * Licence field matches: Yes * Licence file installed: Yes (and included upstream) * Spec file in American English: Yes * Source matches upstream: Yes * Locales use %find_lang: N/A * Contains %clean: Yes * %install contain rm -rf %{buildroot} or similar: Yes * Specfile legible: Yes * Compiles and builds ok: Yes (mock/fc6/x86_64) * Calls ldconfig in %post/%postun for shlibs: N/A * Owns directories it creates: Yes * Duplicate files: No * Permissions set correctly: Yes * Consistent macro use: Yes * Separate -doc needed (for large docs): Not Needed * %doc affects runtime: N/A * Headers and static libs in -devel: N/A * .pc files in -devel: N/A * .so in -devel: N/A * -devel requires base: N/A * Contains .la files: N/A * Owns files it didn't create: No * .desktop files included and installed correctly: Yes * Filenames valid UTF8: Yes 1. Uses a "non standard" buildroot. You may wish to change that to: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) 2. The README file seems useless to me and probably shouldn't be installed. Other than that, the package seems good. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review