https://bugzilla.redhat.com/show_bug.cgi?id=1721409 --- Comment #3 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #1) > My preference is against abbreviations and continuations: > - %global desc %{expand: \ > - %description > - %{desc} > + %global _description %{expand: > + %description %_description > This will actually remove an unneeded empty line at the beginning of > Description. Will the subpackage descriptions then similarly become: %description -n python3-%{pypi_name} %_description ? > > > PyLaTeX is a Python library for creating and compiling LaTeX files or snippets. > > The goal of this library is being an easy, but extensible interface between > Either add a comma after "extensible", or remove the one before "but". Having > one but not the other is wrong, because it makes encourages the reader to > parse > "but extensible interface" as subordinate sentence. Tweaked. (It's upstream's description) > > > nosetests-3 tests/* > Are notestests required? pytest is supported better. Upstream does it like this, so I'd like to leave it as it is: https://github.com/JelteF/PyLaTeX/blob/master/testall.sh#L69 > > > pushd docs || exit -1 > -1 is strange. It is the same as 255 in this context, and usually means > "killed by a signal". 1 would be better. > But pushd already returns an error, so '|| exit ...' should not be necessary > at all. > And in fact, pushd is also unecessary: > > make -C docs SPHINXBUILD=sphinx-build-3 html Of course! Updated. Still got a pushd in there for the fixes, though. > > > BuildRequires: tex(alltt.sty) > > BuildRequires: tex(amsmath.sty) > > BuildRequires: tex(booktabs.sty) > ... > > That's painful. Hopefully this can be replaced by DynamicBuildrequires in > the near future. I had a look at the DynamicBuildRequires page, but I'm not clear how it would pick up all of these tbh. One has to go through the code and figure them out. > > + package name is OK > + license is acceptable for Fedora (MIT) > + license is specified correctly > + builds and installs OK > + BR/R/P look OK (if a bit tedious) > + %python_provide macro is present > + fedora-review and rpmlint are happy > > Package is APPROVED. Thanks very much! Requesting repository now! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
