https://bugzilla.redhat.com/show_bug.cgi?id=1668010 --- Comment #10 from Felix Schwarz <fschwarz@xxxxxxxxxxxxxxxxx> --- License: MIT and GPL and BSD and BSL I think "GPL" was added because of "hip.lang" for gedit. "BSD" is used for two example applications in "samples". That code is not shipped in the final binaries as far as I can see so it should not be present in the License tag. "BSL" probably refers to the boost software license (short name "Boost"). -> License: MIT and Boost Also https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_multiple_licensing_scenarios says: > In addition, the package must contain a comment explaining the multiple licensing breakdown. Only pstream.h uses the boost license and only "lpl" includes it so it should be easy to document in "%files" that lpl is under "MIT AND Boot". Requires: bintuils Typo: "binutils" I tried to compile "vectoradd_hip.cpp" (https://github.com/ROCm-Developer-Tools/HIP-Examples/blob/master/vectorAdd/vectoradd_hip.cpp) with hipcc which caused this error: $ hipcc `hipconfig --cpp_config` vectoradd_hip.cpp -o vectoradd_hip In file included from vectoradd_hip.cpp:27: In file included from /usr//include/hip/hip_runtime.h:56: In file included from /usr//include/hip/hcc_detail/hip_runtime.h:96: In file included from /usr//include/hip/hcc_detail/grid_launch_GGL.hpp:26: In file included from /usr//include/hip/hcc_detail/functional_grid_launch.hpp:25: /usr//include/hip/hcc_detail/code_object_bundle.hpp:25:10: fatal error: 'hsa/hsa.h' file not found #include <hsa/hsa.h> ^~~~~~~~~~~ 1 error generated. Unless I made a mistake (using F30 with a custom recompile of the rawhide SRPMs) I think you also must depend on "rocm-runtime-devel". My biggest gripe is how to deal with "libhip_hcc_static.a" properly (https://docs.fedoraproject.org/en-US/packaging-guidelines/#packaging-static-libraries). A -devel package does not make much sense for hip and as far as I can see upstream does not provide a way to prevent static linking with hipcc. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
