https://bugzilla.redhat.com/show_bug.cgi?id=1719798 Jerry James <loganjerry@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #7 from Jerry James <loganjerry@xxxxxxxxx> --- (In reply to Robert-André Mauchin from comment #4) > 2. Not necessary as the needed libs are autodetected but ok My reading of https://docs.fedoraproject.org/en-US/packaging-guidelines/#_requiring_base_package is that dependencies between subpackages must always be explicit, but perhaps I am reading it incorrectly. > 4. I fixed the build flags. But I need to keep mavx for this package, the > code is specifically designed for it, removing it would hinder performance > greatly. Hinder performance, or make it not work at all? If the former, then I think you should seriously consider the approach in the blog post referenced above. Otherwise, you are almost guaranteed to have people filing bugs against this package complaining that they got an illegal instruction error. It turns out that "-z noexecstack" is needed in the link flags. Rpmlint now complains: svt-av1-libs.x86_64: W: executable-stack /usr/lib64/libSvtAv1Dec.so.1.3.0 svt-av1-libs.x86_64: W: executable-stack /usr/lib64/libSvtAv1Enc.so.1.3.0 > 6. Can't do. The tests needs to git clone a custom fork of aom during build, > which is not possible in Koji/Mock. Okay. It was worth asking. :-) I will go ahead and approve this package. Add -z noexecstack back into the link flags before you commit. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
