https://bugzilla.redhat.com/show_bug.cgi?id=1718997 --- Comment #2 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- (In reply to Antonio Trande from comment #1) > Hi Ankur. Heya, Thanks for the review :) > Test command does not exist: > > + cd pyfim-6.28 > + /usr/bin/python3 setup.py test > BUILDSTDERR: usage: setup.py [global_opts] cmd1 [cmd1_opts] [cmd2 > [cmd2_opts] ...] > BUILDSTDERR: or: setup.py --help [cmd1 cmd2 ...] > BUILDSTDERR: or: setup.py --help-commands > BUILDSTDERR: or: setup.py cmd --help > BUILDSTDERR: error: invalid command 'test' > BUILDSTDERR: error: Bad exit status from /var/tmp/rpm-tmp.0UPjGt (%check) > > Have you tested the src rpm with Mock? Yeh, here's another scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=35509974 The tests are disabled using the `bcond`. I've left that in there so that if upstream does include tests in the future, we can enable them easily. > > %{python3_sitearch}/fim.cpython-37m-*.so > > Use the macros: > > %{python3_sitearch}/fim.cpython-%{python3_version_nodots}$(python3-config --abiflags)-*.so This doesn't work for me somehow. So I've left out the `python3-config...` bit. Here are the updated spec/srpm: Spec URL: https://ankursinha.fedorapeople.org/python-pyfim/python-pyfim.spec SRPM URL: https://ankursinha.fedorapeople.org/python-pyfim/python-pyfim-6.28-1.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx