https://bugzilla.redhat.com/show_bug.cgi?id=1716196 --- Comment #3 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- (In reply to Robert Scheck from comment #2) > First of all, thank you very much for the package review! > > (In reply to Robert-André Mauchin from comment #1) > > - Simplify Source: > > Will fix that, thank you for the pointer. > > > - Not sure it is judicious to split the python lib into a separate > > subpackage? If the package is only used as a binary you can safely put > > everything into the main package. > > What do you mean by that exactly? I've packaged msoffcrypto-tool because of > the python library (for python-oletools). > > Is your proposal about including the msoffcrypto-tool into the python3 > subpackage? Honestly, I've thought about it, but I'm not sure due to the > different package name for users…I've had the hope that the reviewer has a > stronger opinion on it than I ;-) If it is meant to be also used as a library, then keep it separate as you did. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
