https://bugzilla.redhat.com/show_bug.cgi?id=1718685 --- Comment #4 from José Matos <jamatos@xxxxxxxx> --- (In reply to Robert-André Mauchin from comment #3) > - The goal of touching files: > > touch -r $lib $lib.new && > mv $lib.new $lib > > is to keep timestamps, removing this will remove original timestamps. My reading from the guidelines is that this is not necessary: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_shebang_lines I do not mind changing the timestamps because we are really changing the files. If you insist I will do it but it seems to me overkill to retain the original timestamp. > - Capitalize summaries: > > python-smartypants-doc.noarch: W: summary-not-capitalized C smartypants > documentation > > > Summary: plug-in that easily translates ASCII punctuation characters > into smart entities > > Summary: python-smartypants documentation > > > Package approved. Please fix the aforementioned issue before import. I will fix the first. The second seems to me that it is not necessary, the name of the package is in small caps. :-) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
